From: Randy Dunlap <rdunlap@xenotime.net>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: any value in centralizing a defn of "RUN_AT()"?
Date: Mon, 16 May 2011 08:21:53 -0700 [thread overview]
Message-ID: <20110516082153.b55d3f85.rdunlap@xenotime.net> (raw)
In-Reply-To: <alpine.DEB.2.00.1105151616530.28104@localhost6.localdomain6>
On Sun, 15 May 2011 16:18:17 -0400 (EDT) Robert P. J. Day wrote:
>
> i notice that a number of drivers duplicate a macro definition of
> RUN_AT():
>
> drivers/staging/vt6655/device.h:#define RUN_AT(x) (jiffies+(x))
> drivers/net/irda/au1k_ir.c:#define RUN_AT(x) (jiffies + (x))
> drivers/net/hamachi.c:#define RUN_AT(x) (jiffies + (x))
> drivers/net/tulip/tulip.h:#define RUN_AT(x) (jiffies + (x))
> drivers/net/wireless/airo.c:#define RUN_AT(x) (jiffies+(x))
> drivers/net/rrunner.c:#define RUN_AT(x) (jiffies + (x))
> drivers/net/bnx2.c:#define RUN_AT(x) (jiffies + (x))
> drivers/net/3c59x.c:#define RUN_AT(x) (jiffies + (x))
> drivers/net/fealnx.c:#define RUN_AT(x) (jiffies + (x))
>
> etc, etc. any value in just defining that once in jiffies.h and
> letting everyone use that?
Yes IMO.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
prev parent reply other threads:[~2011-05-16 15:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-15 20:18 Robert P. J. Day
2011-05-16 15:21 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110516082153.b55d3f85.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®