* any value in centralizing a defn of "RUN_AT()"?
@ 2011-05-15 20:18 Robert P. J. Day
2011-05-16 15:21 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2011-05-15 20:18 UTC (permalink / raw)
To: Linux Kernel Mailing List
i notice that a number of drivers duplicate a macro definition of
RUN_AT():
drivers/staging/vt6655/device.h:#define RUN_AT(x) (jiffies+(x))
drivers/net/irda/au1k_ir.c:#define RUN_AT(x) (jiffies + (x))
drivers/net/hamachi.c:#define RUN_AT(x) (jiffies + (x))
drivers/net/tulip/tulip.h:#define RUN_AT(x) (jiffies + (x))
drivers/net/wireless/airo.c:#define RUN_AT(x) (jiffies+(x))
drivers/net/rrunner.c:#define RUN_AT(x) (jiffies + (x))
drivers/net/bnx2.c:#define RUN_AT(x) (jiffies + (x))
drivers/net/3c59x.c:#define RUN_AT(x) (jiffies + (x))
drivers/net/fealnx.c:#define RUN_AT(x) (jiffies + (x))
etc, etc. any value in just defining that once in jiffies.h and
letting everyone use that?
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: any value in centralizing a defn of "RUN_AT()"?
2011-05-15 20:18 any value in centralizing a defn of "RUN_AT()"? Robert P. J. Day
@ 2011-05-16 15:21 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2011-05-16 15:21 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: Linux Kernel Mailing List
On Sun, 15 May 2011 16:18:17 -0400 (EDT) Robert P. J. Day wrote:
>
> i notice that a number of drivers duplicate a macro definition of
> RUN_AT():
>
> drivers/staging/vt6655/device.h:#define RUN_AT(x) (jiffies+(x))
> drivers/net/irda/au1k_ir.c:#define RUN_AT(x) (jiffies + (x))
> drivers/net/hamachi.c:#define RUN_AT(x) (jiffies + (x))
> drivers/net/tulip/tulip.h:#define RUN_AT(x) (jiffies + (x))
> drivers/net/wireless/airo.c:#define RUN_AT(x) (jiffies+(x))
> drivers/net/rrunner.c:#define RUN_AT(x) (jiffies + (x))
> drivers/net/bnx2.c:#define RUN_AT(x) (jiffies + (x))
> drivers/net/3c59x.c:#define RUN_AT(x) (jiffies + (x))
> drivers/net/fealnx.c:#define RUN_AT(x) (jiffies + (x))
>
> etc, etc. any value in just defining that once in jiffies.h and
> letting everyone use that?
Yes IMO.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-16 15:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-15 20:18 any value in centralizing a defn of "RUN_AT()"? Robert P. J. Day
2011-05-16 15:21 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®