* [PATCH] PM: Remove CONFIG_PM_VERBOSE
@ 2011-05-13 22:42 Rafael J. Wysocki
2011-05-16 18:32 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki @ 2011-05-13 22:42 UTC (permalink / raw)
To: Linux PM mailing list; +Cc: LKML, linux-sh
From: Rafael J. Wysocki <rjw@sisk.pl>
Now that we have CONFIG_DYNAMIC_DEBUG there is no need for yet
another flag causing dev_dbg() and pr_debug() statements in the
core PM code to produce output. Moreover, CONFIG_PM_VERBOSE
causes so much output to be generated that it's not really useful
and almost no one sets it.
References: https://bugzilla.kernel.org/show_bug.cgi?id=23182
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
arch/sh/configs/apsh4ad0a_defconfig | 1 -
arch/sh/configs/sdk7786_defconfig | 1 -
drivers/base/power/Makefile | 3 +--
kernel/power/Kconfig | 6 ------
4 files changed, 1 insertion(+), 10 deletions(-)
Index: linux-2.6/arch/sh/configs/apsh4ad0a_defconfig
===================================================================
--- linux-2.6.orig/arch/sh/configs/apsh4ad0a_defconfig
+++ linux-2.6/arch/sh/configs/apsh4ad0a_defconfig
@@ -48,7 +48,6 @@ CONFIG_PREEMPT=y
CONFIG_BINFMT_MISC=y
CONFIG_PM=y
CONFIG_PM_DEBUG=y
-CONFIG_PM_VERBOSE=y
CONFIG_PM_RUNTIME=y
CONFIG_CPU_IDLE=y
CONFIG_NET=y
Index: linux-2.6/arch/sh/configs/sdk7786_defconfig
===================================================================
--- linux-2.6.orig/arch/sh/configs/sdk7786_defconfig
+++ linux-2.6/arch/sh/configs/sdk7786_defconfig
@@ -83,7 +83,6 @@ CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS=y
CONFIG_BINFMT_MISC=y
CONFIG_PM=y
CONFIG_PM_DEBUG=y
-CONFIG_PM_VERBOSE=y
CONFIG_PM_RUNTIME=y
CONFIG_CPU_IDLE=y
CONFIG_NET=y
Index: linux-2.6/drivers/base/power/Makefile
===================================================================
--- linux-2.6.orig/drivers/base/power/Makefile
+++ linux-2.6/drivers/base/power/Makefile
@@ -5,5 +5,4 @@ obj-$(CONFIG_PM_TRACE_RTC) += trace.o
obj-$(CONFIG_PM_OPP) += opp.o
obj-$(CONFIG_HAVE_CLK) += clock_ops.o
-ccflags-$(CONFIG_DEBUG_DRIVER) := -DDEBUG
-ccflags-$(CONFIG_PM_VERBOSE) += -DDEBUG
+ccflags-$(CONFIG_DEBUG_DRIVER) := -DDEBUG
\ No newline at end of file
Index: linux-2.6/kernel/power/Kconfig
===================================================================
--- linux-2.6.orig/kernel/power/Kconfig
+++ linux-2.6/kernel/power/Kconfig
@@ -125,12 +125,6 @@ config PM_DEBUG
code. This is helpful when debugging and reporting PM bugs, like
suspend support.
-config PM_VERBOSE
- bool "Verbose Power Management debugging"
- depends on PM_DEBUG
- ---help---
- This option enables verbose messages from the Power Management code.
-
config PM_ADVANCED_DEBUG
bool "Extra PM attributes in sysfs for low-level debugging/testing"
depends on PM_DEBUG
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PM: Remove CONFIG_PM_VERBOSE
2011-05-13 22:42 [PATCH] PM: Remove CONFIG_PM_VERBOSE Rafael J. Wysocki
@ 2011-05-16 18:32 ` Rafael J. Wysocki
2011-05-19 13:07 ` Pavel Machek
0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki @ 2011-05-16 18:32 UTC (permalink / raw)
To: Linux PM mailing list; +Cc: LKML, linux-sh
On Saturday, May 14, 2011, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Now that we have CONFIG_DYNAMIC_DEBUG there is no need for yet
> another flag causing dev_dbg() and pr_debug() statements in the
> core PM code to produce output. Moreover, CONFIG_PM_VERBOSE
> causes so much output to be generated that it's not really useful
> and almost no one sets it.
>
> References: https://bugzilla.kernel.org/show_bug.cgi?id=23182
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
There are no comments, so my understanding is that no one has any objections to
this patch. If that really is the case, I'm going to put it into
suspend-2.6/linux-next for 2.6.40.
Thanks,
Rafael
> ---
> arch/sh/configs/apsh4ad0a_defconfig | 1 -
> arch/sh/configs/sdk7786_defconfig | 1 -
> drivers/base/power/Makefile | 3 +--
> kernel/power/Kconfig | 6 ------
> 4 files changed, 1 insertion(+), 10 deletions(-)
>
> Index: linux-2.6/arch/sh/configs/apsh4ad0a_defconfig
> ===================================================================
> --- linux-2.6.orig/arch/sh/configs/apsh4ad0a_defconfig
> +++ linux-2.6/arch/sh/configs/apsh4ad0a_defconfig
> @@ -48,7 +48,6 @@ CONFIG_PREEMPT=y
> CONFIG_BINFMT_MISC=y
> CONFIG_PM=y
> CONFIG_PM_DEBUG=y
> -CONFIG_PM_VERBOSE=y
> CONFIG_PM_RUNTIME=y
> CONFIG_CPU_IDLE=y
> CONFIG_NET=y
> Index: linux-2.6/arch/sh/configs/sdk7786_defconfig
> ===================================================================
> --- linux-2.6.orig/arch/sh/configs/sdk7786_defconfig
> +++ linux-2.6/arch/sh/configs/sdk7786_defconfig
> @@ -83,7 +83,6 @@ CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS=y
> CONFIG_BINFMT_MISC=y
> CONFIG_PM=y
> CONFIG_PM_DEBUG=y
> -CONFIG_PM_VERBOSE=y
> CONFIG_PM_RUNTIME=y
> CONFIG_CPU_IDLE=y
> CONFIG_NET=y
> Index: linux-2.6/drivers/base/power/Makefile
> ===================================================================
> --- linux-2.6.orig/drivers/base/power/Makefile
> +++ linux-2.6/drivers/base/power/Makefile
> @@ -5,5 +5,4 @@ obj-$(CONFIG_PM_TRACE_RTC) += trace.o
> obj-$(CONFIG_PM_OPP) += opp.o
> obj-$(CONFIG_HAVE_CLK) += clock_ops.o
>
> -ccflags-$(CONFIG_DEBUG_DRIVER) := -DDEBUG
> -ccflags-$(CONFIG_PM_VERBOSE) += -DDEBUG
> +ccflags-$(CONFIG_DEBUG_DRIVER) := -DDEBUG
> \ No newline at end of file
> Index: linux-2.6/kernel/power/Kconfig
> ===================================================================
> --- linux-2.6.orig/kernel/power/Kconfig
> +++ linux-2.6/kernel/power/Kconfig
> @@ -125,12 +125,6 @@ config PM_DEBUG
> code. This is helpful when debugging and reporting PM bugs, like
> suspend support.
>
> -config PM_VERBOSE
> - bool "Verbose Power Management debugging"
> - depends on PM_DEBUG
> - ---help---
> - This option enables verbose messages from the Power Management code.
> -
> config PM_ADVANCED_DEBUG
> bool "Extra PM attributes in sysfs for low-level debugging/testing"
> depends on PM_DEBUG
> --
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PM: Remove CONFIG_PM_VERBOSE
2011-05-16 18:32 ` Rafael J. Wysocki
@ 2011-05-19 13:07 ` Pavel Machek
0 siblings, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2011-05-19 13:07 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Linux PM mailing list, LKML, linux-sh
On Mon 2011-05-16 20:32:33, Rafael J. Wysocki wrote:
> On Saturday, May 14, 2011, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > Now that we have CONFIG_DYNAMIC_DEBUG there is no need for yet
> > another flag causing dev_dbg() and pr_debug() statements in the
> > core PM code to produce output. Moreover, CONFIG_PM_VERBOSE
> > causes so much output to be generated that it's not really useful
> > and almost no one sets it.
> >
> > References: https://bugzilla.kernel.org/show_bug.cgi?id=23182
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
ACK
> There are no comments, so my understanding is that no one has any objections to
> this patch. If that really is the case, I'm going to put it into
> suspend-2.6/linux-next for 2.6.40.
And sorry for slow responses.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-19 13:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-13 22:42 [PATCH] PM: Remove CONFIG_PM_VERBOSE Rafael J. Wysocki
2011-05-16 18:32 ` Rafael J. Wysocki
2011-05-19 13:07 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®