From: Greg KH <greg@kroah.com>
To: anish singh <anish198519851985@gmail.com>
Cc: teddy.wang@siliconmotion.com.cn,
linux-kernel-mail <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3][STAGING SM7XX-cleanup-resend]:removing extra spaces,redundant code and using macros
Date: Tue, 17 May 2011 22:03:26 -0700 [thread overview]
Message-ID: <20110518050326.GB24943@kroah.com> (raw)
In-Reply-To: <BANLkTi=d8EA8Z82rDqpL77iivKq-V1ix0w@mail.gmail.com>
On Wed, May 18, 2011 at 08:41:32AM +0530, anish singh wrote:
> Hi Greg,
>
> Resending all the 3 patches.
> Subject line:
> [PATCH 1/3][STAGING SM7XX-cleanup-resend]:removing extra spaces,redundant code
> and using macros
> [PATCH 2/3][STAGING SM7XX-cleanup-resend]:preferred form for passing a size to
> memory allocation routines
> [PATCH 3/3][STAGING SM7XX-cleanup-resend]:printk loglevels modified to match
> the scenario
This does not belong in the 1/3 patch, and neither does that extra
information in the [].
Your patches should look like:
[PATCH 1/3] Staging: sm7xx: remove extra whitespace
and the like.
> This patch is to remove extra spaces,redundant code and using
> ARRAY_SIZE macros.
> Signed-off-by: anish kumar<anish198519851985@gmail.com>
You need an extra line before the Signed-off-by: line.
And an extra space after your name and before the '<'
Care to try it all again?
greg k-h
parent reply other threads:[~2011-05-18 5:03 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <BANLkTi=d8EA8Z82rDqpL77iivKq-V1ix0w@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110518050326.GB24943@kroah.com \
--to=greg@kroah.com \
--cc=anish198519851985@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=teddy.wang@siliconmotion.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®