* Re: [PATCH 1/3][STAGING SM7XX-cleanup-resend]:removing extra spaces,redundant code and using macros
[not found] <BANLkTi=d8EA8Z82rDqpL77iivKq-V1ix0w@mail.gmail.com>
@ 2011-05-18 5:03 ` Greg KH
0 siblings, 0 replies; only message in thread
From: Greg KH @ 2011-05-18 5:03 UTC (permalink / raw)
To: anish singh; +Cc: teddy.wang, linux-kernel-mail
On Wed, May 18, 2011 at 08:41:32AM +0530, anish singh wrote:
> Hi Greg,
>
> Resending all the 3 patches.
> Subject line:
> [PATCH 1/3][STAGING SM7XX-cleanup-resend]:removing extra spaces,redundant code
> and using macros
> [PATCH 2/3][STAGING SM7XX-cleanup-resend]:preferred form for passing a size to
> memory allocation routines
> [PATCH 3/3][STAGING SM7XX-cleanup-resend]:printk loglevels modified to match
> the scenario
This does not belong in the 1/3 patch, and neither does that extra
information in the [].
Your patches should look like:
[PATCH 1/3] Staging: sm7xx: remove extra whitespace
and the like.
> This patch is to remove extra spaces,redundant code and using
> ARRAY_SIZE macros.
> Signed-off-by: anish kumar<anish198519851985@gmail.com>
You need an extra line before the Signed-off-by: line.
And an extra space after your name and before the '<'
Care to try it all again?
greg k-h
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-05-18 5:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <BANLkTi=d8EA8Z82rDqpL77iivKq-V1ix0w@mail.gmail.com>
2011-05-18 5:03 ` [PATCH 1/3][STAGING SM7XX-cleanup-resend]:removing extra spaces,redundant code and using macros Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®