From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Kyungmin Park <kmpark@infradead.org>,
Andrew Lunn <andrew@lunn.ch>,
linux-kernel@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
Martin Persson <martin.persson@stericsson.com>,
Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/4] Pinmux subsystem
Date: Wed, 18 May 2011 22:21:55 +0100 [thread overview]
Message-ID: <20110518212154.GA20909@sirena.org.uk> (raw)
In-Reply-To: <BANLkTikUbxHQH-sAP+uOy7bnpZcyN_GHxQ@mail.gmail.com>
On Wed, May 18, 2011 at 10:02:47PM +0200, Linus Walleij wrote:
> 2011/5/17 Kyungmin Park <kmpark@infradead.org>:
> > In this case we only need to set the function at interrupt by like
> > s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(0xf));
> > So pinmux function provides this feature also.
> This function:
> s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(0xf));
> Isn't part of the gpiolib I can see, I am discussing with Grant
> how to handle custom GPIO configuration. Looking in
> archa/arm/plat-samsung/include/plat/gpio-core.h
> it looks like you have your own reimplementation of the
> entire gpiolib in order to get these special configuration
> functions... (So hopefully if I can add custom GPIO
> configs to gpiolib, all of this can move to drivers/gpio/*)
This API predates the generic GPIO API - it's a reimplementation because
at that time the various platforms all had their own custom APIs. The
Samsung specific API is pretty much only used for the pin mux and mode
configuration these days.
next prev parent reply other threads:[~2011-05-18 21:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 19:16 Linus Walleij
2011-05-02 22:57 ` Russell King - ARM Linux
2011-05-10 21:25 ` Linus Walleij
2011-05-10 21:45 ` Russell King - ARM Linux
2011-05-10 23:15 ` Linus Walleij
2011-05-03 17:27 ` Andrew Lunn
2011-05-03 19:29 ` Valdis.Kletnieks
2011-05-10 21:42 ` Linus Walleij
2011-05-11 9:50 ` Andrew Lunn
2011-05-12 0:41 ` Linus Walleij
2011-05-12 7:00 ` Andrew Lunn
2011-05-15 13:33 ` Andrew Lunn
2011-05-15 17:50 ` Linus Walleij
2011-05-17 1:57 ` Kyungmin Park
2011-05-18 20:02 ` Linus Walleij
2011-05-18 21:21 ` Mark Brown [this message]
2011-05-12 7:44 ` Sascha Hauer
2011-05-12 9:40 ` Tony Lindgren
2011-05-12 14:02 ` Linus Walleij
2011-05-12 21:17 ` RE : " Matthieu Castet
2011-05-13 7:05 ` Linus Walleij
2011-05-13 16:03 ` Matthieu CASTET
2011-05-14 7:57 ` Linus Walleij
2011-05-13 9:59 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110518212154.GA20909@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=andrew@lunn.ch \
--cc=grant.likely@secretlab.ca \
--cc=kmpark@infradead.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.persson@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome