From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Shawn Guo <shawn.guo@linaro.org>,
linux-kernel@vger.kernel.org, patches@linaro.org,
linus.walleij@linaro.org, grant.likely@secretlab.ca,
kernel@pengutronix.de
Subject: Re: [PATCH 1/3] ARM: mxs: remove gpio driver from mach-mxs
Date: Fri, 20 May 2011 12:04:59 +0200 [thread overview]
Message-ID: <201105201204.59237.arnd@arndb.de> (raw)
In-Reply-To: <1305885446-27404-2-git-send-email-shawn.guo@linaro.org>
On Friday 20 May 2011 11:57:24 Shawn Guo wrote:
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> arch/arm/mach-mxs/Makefile | 2 +-
> arch/arm/mach-mxs/gpio.c | 331 --------------------------------------
> arch/arm/mach-mxs/gpio.h | 34 ----
> arch/arm/mach-mxs/mach-mx28evk.c | 1 -
> arch/arm/mach-mxs/mm-mx23.c | 1 -
> arch/arm/mach-mxs/mm-mx28.c | 1 -
> 6 files changed, 1 insertions(+), 369 deletions(-)
> delete mode 100644 arch/arm/mach-mxs/gpio.c
> delete mode 100644 arch/arm/mach-mxs/gpio.h
The patch looks good (removing stuff often is), but
you are missing a changelog. Please explain why it's
not used any more so that people can find it later
when they only look at git but not at your original
mail 0/3 or the entire series.
Arnd
next prev parent reply other threads:[~2011-05-20 10:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 9:57 [PATCH 0/3] remove mach-mxs gpio driver Shawn Guo
2011-05-20 9:57 ` [PATCH 1/3] ARM: mxs: remove gpio driver from mach-mxs Shawn Guo
2011-05-20 10:04 ` Arnd Bergmann [this message]
2011-05-20 10:27 ` Shawn Guo
2011-05-20 9:57 ` [PATCH 2/3] ARM: mxs: add gpio-mxs platform devices Shawn Guo
2011-05-20 10:23 ` Arnd Bergmann
2011-05-20 14:03 ` Shawn Guo
2011-05-20 14:23 ` Arnd Bergmann
2011-05-20 14:40 ` Shawn Guo
2011-05-27 9:11 ` Shawn Guo
2011-05-27 11:10 ` Arnd Bergmann
2011-05-27 8:29 ` Shawn Guo
2011-05-27 8:48 ` Arnd Bergmann
2011-05-20 9:57 ` [PATCH 3/3] ARM: mxs: select GPIO_MXS for i.MX23 and i.MX28 Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105201204.59237.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=grant.likely@secretlab.ca \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome