* [PATCH] Properly assign return value of clamp() macro.
@ 2011-05-23 19:58 Hans Petter Selasky
2011-05-25 16:18 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Hans Petter Selasky @ 2011-05-23 19:58 UTC (permalink / raw)
To: linux-kernel
>From 2b7fc579e802357b7b0742bf6bbbabdaf9e40c1e Mon Sep 17 00:00:00 2001
From: Hans Petter Selasky <hselasky@c2i.net>
Date: Mon, 23 May 2011 21:54:42 +0200
Subject: [PATCH] Properly assign return value of clamp() macro.
Signed-off-by: Hans Petter Selasky <hselasky@c2i.net>
---
drivers/input/input.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/input.c b/drivers/input/input.c
index ebbceed..e3c88fc 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -1757,7 +1757,7 @@ static unsigned int
input_estimate_events_per_packet(struct input_dev *dev)
} else if (test_bit(ABS_MT_TRACKING_ID, dev->absbit)) {
mt_slots = dev->absinfo[ABS_MT_TRACKING_ID].maximum -
dev->absinfo[ABS_MT_TRACKING_ID].minimum + 1,
- clamp(mt_slots, 2, 32);
+ mt_slots = clamp(mt_slots, 2, 32);
} else if (test_bit(ABS_MT_POSITION_X, dev->absbit)) {
mt_slots = 2;
} else {
--
1.7.1.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] Properly assign return value of clamp() macro.
2011-05-23 19:58 [PATCH] Properly assign return value of clamp() macro Hans Petter Selasky
@ 2011-05-25 16:18 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2011-05-25 16:18 UTC (permalink / raw)
To: Hans Petter Selasky; +Cc: linux-kernel
On Mon, May 23, 2011 at 09:58:34PM +0200, Hans Petter Selasky wrote:
> From 2b7fc579e802357b7b0742bf6bbbabdaf9e40c1e Mon Sep 17 00:00:00 2001
> From: Hans Petter Selasky <hselasky@c2i.net>
> Date: Mon, 23 May 2011 21:54:42 +0200
> Subject: [PATCH] Properly assign return value of clamp() macro.
>
> Signed-off-by: Hans Petter Selasky <hselasky@c2i.net>
Applied, thanks Hans Peter. I am not sure why I thought clamp() was
modifying its argument... I added similar change to mousedev as well.
> ---
> drivers/input/input.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/input.c b/drivers/input/input.c
> index ebbceed..e3c88fc 100644
> --- a/drivers/input/input.c
> +++ b/drivers/input/input.c
> @@ -1757,7 +1757,7 @@ static unsigned int
> input_estimate_events_per_packet(struct input_dev *dev)
> } else if (test_bit(ABS_MT_TRACKING_ID, dev->absbit)) {
> mt_slots = dev->absinfo[ABS_MT_TRACKING_ID].maximum -
> dev->absinfo[ABS_MT_TRACKING_ID].minimum + 1,
> - clamp(mt_slots, 2, 32);
> + mt_slots = clamp(mt_slots, 2, 32);
> } else if (test_bit(ABS_MT_POSITION_X, dev->absbit)) {
> mt_slots = 2;
> } else {
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-25 16:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-23 19:58 [PATCH] Properly assign return value of clamp() macro Hans Petter Selasky
2011-05-25 16:18 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome