From: Alexander Stein <alexander.stein@systec-electronic.com>
To: "Tomoya MORINAGA" <tomoya-linux@dsn.okisemi.com>
Cc: "'Grant Likely'" <grant.likely@secretlab.ca>,
linux-kernel@vger.kernel.org, qi.wang@intel.com,
yong.y.wang@intel.com, joel.clark@intel.com,
kok.howg.ewe@intel.com, toshiharu-linux@dsn.okisemi.com
Subject: Re: [PATCH] pch_gpio: support interrupt function
Date: Wed, 25 May 2011 14:03:56 +0200 [thread overview]
Message-ID: <201105251403.58051.alexander.stein@systec-electronic.com> (raw)
In-Reply-To: <1A7613A496994F5AA69F0142CFDF892B@hacdom.okisemi.com>
Hello Tomoya,
On Wednesday 25 May 2011 02:03:54 Tomoya MORINAGA wrote:
> > This patch doesn't apply to v2.6.39. There are some more or
> > less trivial fixes needed. But it doesn't compile anyway.
>
> I want to update your indications to our driver.
> Would you show it ?
These are my compilation messages:
CC drivers/gpio/pch_gpio.o
drivers/gpio/pch_gpio.c: In function 'pch_irq_type':
drivers/gpio/pch_gpio.c:195:9: error: implicit declaration of function
'get_irq_chip_data'
drivers/gpio/pch_gpio.c:195:26: warning: initialization makes pointer from
integer without a cast
drivers/gpio/pch_gpio.c: At top level:
drivers/gpio/pch_gpio.c:256:2: error: unknown field 'mask' specified in
initializer
drivers/gpio/pch_gpio.c:256:2: warning: initialization from incompatible
pointer type
drivers/gpio/pch_gpio.c:257:2: error: unknown field 'unmask' specified in
initializer
drivers/gpio/pch_gpio.c:257:2: warning: initialization from incompatible
pointer type
drivers/gpio/pch_gpio.c:258:2: error: unknown field 'set_type' specified in
initializer
drivers/gpio/pch_gpio.c:258:2: warning: initialization from incompatible
pointer type
drivers/gpio/pch_gpio.c: In function 'pch_gpio_probe':
drivers/gpio/pch_gpio.c:339:3: error: implicit declaration of function
'set_irq_chip_and_handler_name'
drivers/gpio/pch_gpio.c:341:3: error: implicit declaration of function
'set_irq_chip_data'
If you need/want the actual patch I can mail it.
It seems starting with commit 0c6f8a8b917ad361319c8ace3e9f28e69bfdb4c1
"genirq: Remove compat code" get_irq_chip_data and friends are removed.
Regards,
Alexander
next prev parent reply other threads:[~2011-05-25 12:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 2:46 Tomoya MORINAGA
2011-05-24 15:45 ` Alexander Stein
2011-05-25 0:03 ` Tomoya MORINAGA
2011-05-25 12:03 ` Alexander Stein [this message]
2011-05-26 0:15 ` Tomoya MORINAGA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105251403.58051.alexander.stein@systec-electronic.com \
--to=alexander.stein@systec-electronic.com \
--cc=grant.likely@secretlab.ca \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=tomoya-linux@dsn.okisemi.com \
--cc=toshiharu-linux@dsn.okisemi.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®