RE: [PATCH] pch_gpio: support interrupt function

["Tomoya MORINAGA" <tomoya-linux@dsn.okisemi.com>]

Hi Alexander 

> "genirq: Remove compat code" get_irq_chip_data and friends 
You are right.
In 2.6.39, get_irq_chip_data and friends look deleted.

Modifying for 2.6.39, I will post again.

Thanks,
-----------------------------------------
Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.

> -----Original Message-----
> From: Alexander Stein [mailto:alexander.stein@systec-electronic.com] 
> Sent: Wednesday, May 25, 2011 9:04 PM
> To: Tomoya MORINAGA
> Cc: 'Grant Likely'; linux-kernel@vger.kernel.org; 
> qi.wang@intel.com; yong.y.wang@intel.com; 
> joel.clark@intel.com; kok.howg.ewe@intel.com; 
> toshiharu-linux@dsn.okisemi.com
> Subject: Re: [PATCH] pch_gpio: support interrupt function
> 
> Hello Tomoya,
> 
> On Wednesday 25 May 2011 02:03:54 Tomoya MORINAGA wrote:
> > > This patch doesn't apply to v2.6.39. There are some more or less 
> > > trivial fixes needed. But it doesn't compile anyway.
> > 
> > I want to update your indications to our driver.
> > Would you show it ?
> 
> These are my compilation messages:
>   CC      drivers/gpio/pch_gpio.o
> drivers/gpio/pch_gpio.c: In function 'pch_irq_type':
> drivers/gpio/pch_gpio.c:195:9: error: implicit declaration of 
> function 'get_irq_chip_data'
> drivers/gpio/pch_gpio.c:195:26: warning: initialization makes 
> pointer from integer without a cast
> drivers/gpio/pch_gpio.c: At top level:
> drivers/gpio/pch_gpio.c:256:2: error: unknown field 'mask' 
> specified in initializer
> drivers/gpio/pch_gpio.c:256:2: warning: initialization from 
> incompatible pointer type
> drivers/gpio/pch_gpio.c:257:2: error: unknown field 'unmask' 
> specified in initializer
> drivers/gpio/pch_gpio.c:257:2: warning: initialization from 
> incompatible pointer type
> drivers/gpio/pch_gpio.c:258:2: error: unknown field 
> 'set_type' specified in initializer
> drivers/gpio/pch_gpio.c:258:2: warning: initialization from 
> incompatible pointer type
> drivers/gpio/pch_gpio.c: In function 'pch_gpio_probe':
> drivers/gpio/pch_gpio.c:339:3: error: implicit declaration of 
> function 'set_irq_chip_and_handler_name'
> drivers/gpio/pch_gpio.c:341:3: error: implicit declaration of 
> function 'set_irq_chip_data'
> 
> If you need/want the actual patch I can mail it.
> It seems starting with commit 0c6f8a8b917ad361319c8ace3e9f28e69bfdb4c1
> "genirq: Remove compat code" get_irq_chip_data and friends 
> are removed.
> 
> Regards,
> Alexander
>