From: Borislav Petkov <bp@amd64.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ben Blum <bblum@andrew.cmu.edu>,
Stephane Eranian <eranian@google.com>,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: perf cgroup per-task attaching
Date: Tue, 31 May 2011 16:13:12 +0200 [thread overview]
Message-ID: <20110531141312.GB13134@aftab> (raw)
In-Reply-To: <1306850860.2353.111.camel@twins>
On Tue, May 31, 2011 at 10:07:40AM -0400, Peter Zijlstra wrote:
> On Tue, 2011-05-31 at 16:03 +0200, Borislav Petkov wrote:
> > Just FYI:
> >
> > I'm getting
> >
> > kernel/events/core.c:7445: warning: initialization from incompatible pointer type
> >
> > when building -rc1 with CONFIG_CGROUP_PERF enabled. AFAICT, this is
> > due to the fact that f780bdb7c1c73009cb57adcf99ef50027d80bf3c dropped
> > the threadgroup arg from cgroup_subsys->attach in favour of per-thread
> > callbacks.
> >
> > perf_cgroup_attach() actually does reschedule the task context after
> > the cgroup changes so the perf cgroup code would need some non-trivial
> > adjusting to the new APIs.
>
> lkml.kernel.org/r/tip-74c355fbdfedd3820046dba4f537876cea54c207@git.kernel.org
Hehe, that happened today already! :)
Thanks.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
prev parent reply other threads:[~2011-05-31 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 14:03 Borislav Petkov
2011-05-31 14:07 ` Peter Zijlstra
2011-05-31 14:13 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110531141312.GB13134@aftab \
--to=bp@amd64.org \
--cc=a.p.zijlstra@chello.nl \
--cc=bblum@andrew.cmu.edu \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®