* perf cgroup per-task attaching
@ 2011-05-31 14:03 Borislav Petkov
2011-05-31 14:07 ` Peter Zijlstra
0 siblings, 1 reply; 3+ messages in thread
From: Borislav Petkov @ 2011-05-31 14:03 UTC (permalink / raw)
To: Peter Zijlstra, Ben Blum, Stephane Eranian; +Cc: Ingo Molnar, LKML
Just FYI:
I'm getting
kernel/events/core.c:7445: warning: initialization from incompatible pointer type
when building -rc1 with CONFIG_CGROUP_PERF enabled. AFAICT, this is
due to the fact that f780bdb7c1c73009cb57adcf99ef50027d80bf3c dropped
the threadgroup arg from cgroup_subsys->attach in favour of per-thread
callbacks.
perf_cgroup_attach() actually does reschedule the task context after
the cgroup changes so the perf cgroup code would need some non-trivial
adjusting to the new APIs.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: perf cgroup per-task attaching
2011-05-31 14:03 perf cgroup per-task attaching Borislav Petkov
@ 2011-05-31 14:07 ` Peter Zijlstra
2011-05-31 14:13 ` Borislav Petkov
0 siblings, 1 reply; 3+ messages in thread
From: Peter Zijlstra @ 2011-05-31 14:07 UTC (permalink / raw)
To: Borislav Petkov; +Cc: Ben Blum, Stephane Eranian, Ingo Molnar, LKML
On Tue, 2011-05-31 at 16:03 +0200, Borislav Petkov wrote:
> Just FYI:
>
> I'm getting
>
> kernel/events/core.c:7445: warning: initialization from incompatible pointer type
>
> when building -rc1 with CONFIG_CGROUP_PERF enabled. AFAICT, this is
> due to the fact that f780bdb7c1c73009cb57adcf99ef50027d80bf3c dropped
> the threadgroup arg from cgroup_subsys->attach in favour of per-thread
> callbacks.
>
> perf_cgroup_attach() actually does reschedule the task context after
> the cgroup changes so the perf cgroup code would need some non-trivial
> adjusting to the new APIs.
lkml.kernel.org/r/tip-74c355fbdfedd3820046dba4f537876cea54c207@git.kernel.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: perf cgroup per-task attaching
2011-05-31 14:07 ` Peter Zijlstra
@ 2011-05-31 14:13 ` Borislav Petkov
0 siblings, 0 replies; 3+ messages in thread
From: Borislav Petkov @ 2011-05-31 14:13 UTC (permalink / raw)
To: Peter Zijlstra; +Cc: Ben Blum, Stephane Eranian, Ingo Molnar, LKML
On Tue, May 31, 2011 at 10:07:40AM -0400, Peter Zijlstra wrote:
> On Tue, 2011-05-31 at 16:03 +0200, Borislav Petkov wrote:
> > Just FYI:
> >
> > I'm getting
> >
> > kernel/events/core.c:7445: warning: initialization from incompatible pointer type
> >
> > when building -rc1 with CONFIG_CGROUP_PERF enabled. AFAICT, this is
> > due to the fact that f780bdb7c1c73009cb57adcf99ef50027d80bf3c dropped
> > the threadgroup arg from cgroup_subsys->attach in favour of per-thread
> > callbacks.
> >
> > perf_cgroup_attach() actually does reschedule the task context after
> > the cgroup changes so the perf cgroup code would need some non-trivial
> > adjusting to the new APIs.
>
> lkml.kernel.org/r/tip-74c355fbdfedd3820046dba4f537876cea54c207@git.kernel.org
Hehe, that happened today already! :)
Thanks.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-31 14:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-31 14:03 perf cgroup per-task attaching Borislav Petkov
2011-05-31 14:07 ` Peter Zijlstra
2011-05-31 14:13 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®