* slub: UML and CONFIG_CMPXCHG_LOCAL
@ 2011-05-29 20:25 Richard Weinberger
2011-05-31 14:30 ` Christoph Lameter
0 siblings, 1 reply; 3+ messages in thread
From: Richard Weinberger @ 2011-05-29 20:25 UTC (permalink / raw)
To: cl; +Cc: linux-kernel, penberg
Christoph,
With commit 1759415e you've removed all #ifdef CONFIG_CMPXCHG_LOCAL's from slub.
This change breaks slub (again) on UML.
UML does not implement this_cpu_cmpxchg16b_emu().
Starting with 2.6.39 (commit 084189a) I've disabled CONFIG_CMPXCHG_LOCAL on UML do bypass the issue.
This fix does no longer help.
Is there anything I can do to have slub on UML?
Implementing this_cpu_cmpxchg16b_emu for UML is not really an option.
See:
http://comments.gmane.org/gmane.linux.kernel/1125183
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: slub: UML and CONFIG_CMPXCHG_LOCAL
2011-05-29 20:25 slub: UML and CONFIG_CMPXCHG_LOCAL Richard Weinberger
@ 2011-05-31 14:30 ` Christoph Lameter
2011-05-31 15:47 ` Richard Weinberger
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Lameter @ 2011-05-31 14:30 UTC (permalink / raw)
To: Richard Weinberger; +Cc: linux-kernel, penberg
On Sun, 29 May 2011, Richard Weinberger wrote:
> With commit 1759415e you've removed all #ifdef CONFIG_CMPXCHG_LOCAL's from slub.
> This change breaks slub (again) on UML.
> UML does not implement this_cpu_cmpxchg16b_emu().
It does not have to implement it. The this_cpu_ops can fall back to
generic implementations.
> Is there anything I can do to have slub on UML?
Yes, rely on the generic implementation of this_cpu_cmpxchg.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: slub: UML and CONFIG_CMPXCHG_LOCAL
2011-05-31 14:30 ` Christoph Lameter
@ 2011-05-31 15:47 ` Richard Weinberger
0 siblings, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2011-05-31 15:47 UTC (permalink / raw)
To: Christoph Lameter; +Cc: linux-kernel, penberg
Am Dienstag 31 Mai 2011, 16:30:21 schrieb Christoph Lameter:
> > Is there anything I can do to have slub on UML?
>
> Yes, rely on the generic implementation of this_cpu_cmpxchg.
Thanks for the pointer.
You helped me a lot!
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-31 15:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-29 20:25 slub: UML and CONFIG_CMPXCHG_LOCAL Richard Weinberger
2011-05-31 14:30 ` Christoph Lameter
2011-05-31 15:47 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®