From: "Eric Andersson" <eric.andersson@unixphere.com>
To: "Alan Cox" <alan@lxorguk.ukuu.org.uk>, dmitry.torokhov@gmail.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
zhengguang.guo@bosch-sensortec.com, stefan.nilsson@unixphere.com,
"Albert Zhang" <xu.zhang@bosch-sensortec.com>
Subject: Re: [PATCH] input: add driver for Bosch Sensortec's BMA150 accelerometer
Date: Tue, 31 May 2011 22:00:30 +0200 [thread overview]
Message-ID: <20110531200031.01097304A02D@bmail00.one.com> (raw)
In-Reply-To: <20110531172320.0fcadfef@lxorguk.ukuu.org.uk>
On May 31, 2011 18:23 "Alan Cox" <alan@lxorguk.ukuu.org.uk> wrote:
> See the driver I posted some time ago. It's in rather better state than
> this one and as it's been through most of the review process and also
> handles the BMA023 and SMB380 so I think would be a better place to start
> from. I'll report that driver in a moment.
I wasn't aware of that patch! Thanks for pointing it out! Regarding BMA023 and
SMB380, these are also supported by this driver, which should probably have been
stated in the Kconfig file.
> Some of the first immediately obvious questions though - in particular
> the lack of clear locking ...
Thanks for reviewing!
Dimitry, I guess it's up to you to decide which version of the driver you prefer
before we go through another round in the review process.
Best regards,
Eric
http://www.unixphere.com
next prev parent reply other threads:[~2011-05-31 20:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 15:55 Eric Andersson
2011-05-31 16:23 ` Alan Cox
2011-05-31 20:00 ` Eric Andersson [this message]
2011-06-09 16:12 ` Eric Andersson
2011-06-09 16:32 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110531200031.01097304A02D@bmail00.one.com \
--to=eric.andersson@unixphere.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan.nilsson@unixphere.com \
--cc=xu.zhang@bosch-sensortec.com \
--cc=zhengguang.guo@bosch-sensortec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®