From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Eric Andersson <eric.andersson@unixphere.com>
Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, zhengguang.guo@bosch-sensortec.com,
stefan.nilsson@unixphere.com,
Albert Zhang <xu.zhang@bosch-sensortec.com>
Subject: Re: [PATCH] input: add driver for Bosch Sensortec's BMA150 accelerometer
Date: Thu, 9 Jun 2011 17:32:03 +0100 [thread overview]
Message-ID: <20110609173203.020d5017@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20110609161224.GA7098@skinner>
> > What locks this SMBUS transaction against others
> True! I will look over the locking for the next version.
I have a suspicion the two drivers are distant relatives actually - the
bugs look similar !
>
> > > +static int bma150_set_range(struct i2c_client *client, unsigned char range)
> > > +{
> > > + int ret;
> > > + unsigned char data;
> > > +
> > > + if (range > BMA150_RANGE_8G)
> > > + return -EINVAL;
> >
> > This should be actual values not a register range
> It is an actual value. See chapter 3.1.2 in the BMA150 datasheet where the
> acceleration range values are defined.
It should specify the units and be in meaningful ones not register values
(I got moaned at for that in my submission too!)
> I will send an updated version of the driver once I've fixed it!
Cool - I really don't care btw which driver we end up with a mix of both,
I just need it to work on our platform too.
Dunno where Dmitry has gone - has he vanished ?
prev parent reply other threads:[~2011-06-09 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 15:55 Eric Andersson
2011-05-31 16:23 ` Alan Cox
2011-05-31 20:00 ` Eric Andersson
2011-06-09 16:12 ` Eric Andersson
2011-06-09 16:32 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110609173203.020d5017@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=dmitry.torokhov@gmail.com \
--cc=eric.andersson@unixphere.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan.nilsson@unixphere.com \
--cc=xu.zhang@bosch-sensortec.com \
--cc=zhengguang.guo@bosch-sensortec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®