From: Kees Cook <kees.cook@canonical.com>
To: James Morris <jmorris@namei.org>
Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] AppArmor: fix oops in apparmor_setprocattr
Date: Tue, 31 May 2011 19:02:54 -0700 [thread overview]
Message-ID: <20110601020254.GT19633@outflux.net> (raw)
In-Reply-To: <alpine.LRH.2.00.1106011024150.16178@tundra.namei.org>
Hi James,
On Wed, Jun 01, 2011 at 10:25:37AM +1000, James Morris wrote:
> On Tue, 31 May 2011, Kees Cook wrote:
> > When invalid parameters are passed to apparmor_setprocattr a NULL deref
> > oops occurs when it tries to record an audit message. This is because
> > it is passing NULL for the profile parameter for aa_audit. But aa_audit
> > now requires that the profile passed is not NULL.
> >
> > Fix this by passing the current profile on the task that is trying to
> > setprocattr.
>
> Is this trigger able by unprivileged users?
Yes, but the Oops kills the process doing the write as it triggers
the BUG_ON, not the process being written to.
> >From which upstream commit is this an issue?
b5e95b48685e3481139a5634d14d630d12c7d5ce
-Kees
--
Kees Cook
Ubuntu Security Team
prev parent reply other threads:[~2011-06-01 2:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 18:31 Kees Cook
2011-06-01 0:25 ` James Morris
2011-06-01 0:46 ` Tetsuo Handa
2011-06-01 2:02 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110601020254.GT19633@outflux.net \
--to=kees.cook@canonical.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®