From: James Morris <jmorris@namei.org>
To: Kees Cook <kees.cook@canonical.com>
Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] AppArmor: fix oops in apparmor_setprocattr
Date: Wed, 1 Jun 2011 10:25:37 +1000 (EST) [thread overview]
Message-ID: <alpine.LRH.2.00.1106011024150.16178@tundra.namei.org> (raw)
In-Reply-To: <20110531183141.GH19633@outflux.net>
On Tue, 31 May 2011, Kees Cook wrote:
> When invalid parameters are passed to apparmor_setprocattr a NULL deref
> oops occurs when it tries to record an audit message. This is because
> it is passing NULL for the profile parameter for aa_audit. But aa_audit
> now requires that the profile passed is not NULL.
>
> Fix this by passing the current profile on the task that is trying to
> setprocattr.
Is this trigger able by unprivileged users?
>From which upstream commit is this an issue?
- James
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2011-06-01 0:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 18:31 Kees Cook
2011-06-01 0:25 ` James Morris [this message]
2011-06-01 0:46 ` Tetsuo Handa
2011-06-01 2:02 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.00.1106011024150.16178@tundra.namei.org \
--to=jmorris@namei.org \
--cc=kees.cook@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®