From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Mark Einon <mark.einon@gmail.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, o.hartmann@telovital.com
Subject: Re: [PATCH 3/5] staging: et131x: et131x_adapter.h checkpatch fixes
Date: Sun, 5 Jun 2011 20:11:16 +0100 [thread overview]
Message-ID: <20110605201116.4fa28490@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1307295320-31716-4-git-send-email-mark.einon@gmail.com>
On Sun, 5 Jun 2011 18:35:18 +0100
Mark Einon <mark.einon@gmail.com> wrote:
> From: Mark Einon <Mark.Einon@gmail.com>
>
> Fixes a 'WARNING: do not add new typedefs' and line > 80 chars.
Again with the structs the process has been to clean up the field names
to Linux style, then rename the struct so we know what is going on
Can you lose the _t and change the struct to live as adapter->stats ?
Alan
next prev parent reply other threads:[~2011-06-05 19:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-05 17:35 [PATCH 0/5] staging: et131x: " Mark Einon
2011-06-05 17:35 ` [PATCH 1/5] staging: et131x: et1310_address_map.h " Mark Einon
2011-06-05 19:14 ` Alan Cox
2011-06-05 17:35 ` [PATCH 2/5] staging: et131x: et1310_rx.c " Mark Einon
2011-06-05 19:08 ` Alan Cox
2011-06-05 17:35 ` [PATCH 3/5] staging: et131x: et131x_adapter.h " Mark Einon
2011-06-05 19:11 ` Alan Cox [this message]
2011-06-05 17:35 ` [PATCH 4/5] staging: et131x: et131x_initpci.c " Mark Einon
2011-06-05 19:09 ` Alan Cox
2011-06-06 6:00 ` Dan Carpenter
2011-06-05 17:35 ` [PATCH 5/5] staging: et131x: et131x_netdev.c " Mark Einon
2011-06-05 19:10 ` Alan Cox
2011-06-05 19:11 ` [PATCH 0/5] staging: et131x: " Alan Cox
2011-06-06 18:06 ` [PATCH v2 0/7] " Mark Einon
2011-06-06 18:06 ` [PATCH v2 1/7] staging: et131x: checkpatch fixes for et1310_address_map.h (All 'do not add new typedefs') Mark Einon
2011-06-06 18:06 ` [PATCH v2 2/7] staging: et131x: et1310_rx.c checkpatch fixes Mark Einon
2011-06-06 18:07 ` [PATCH v2 3/7] staging: et131x: et131x_adapter.h " Mark Einon
2011-06-06 18:07 ` [PATCH v2 4/7] staging: et131x: et131x_initpci.c " Mark Einon
2011-06-06 18:07 ` [PATCH v2 5/7] staging: et131x: et131x_netdev.c " Mark Einon
2011-06-06 18:07 ` [PATCH v2 6/7] staging: et131x: Fixes multiple 'WARNING: do not add new typedefs' Mark Einon
2011-06-06 18:07 ` [PATCH v2 7/7] staging: et131x: Removing '_t' from ce_stats_t struct Mark Einon
2011-06-06 18:31 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110605201116.4fa28490@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.einon@gmail.com \
--cc=o.hartmann@telovital.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®