From: Jamie Iles <jamie@jamieiles.com>
To: Jamie Iles <jamie@jamieiles.com>
Cc: linux-kernel@vger.kernel.org, Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH] gpio: basic_mmio: add missing include of spinlock_types.h
Date: Fri, 10 Jun 2011 13:48:05 +0100 [thread overview]
Message-ID: <20110610124805.GN3711@pulham.picochip.com> (raw)
In-Reply-To: <1307709889-31350-1-git-send-email-jamie@jamieiles.com>
On Fri, Jun 10, 2011 at 01:44:49PM +0100, Jamie Iles wrote:
> include/linux/basic_mmio_gpio.h uses a spinlock_t without including any
> of the spinlock headers resulting in this compiler warning.
>
> include/linux/basic_mmio_gpio.h:51:2: error: expected specifier-qualifier-list before 'spinlock_t'
>
> Explicitly include linux/spinlock_types.h to fix it.
Sorry, wrong patch. Here's the correct one.
Jamie
8<---
>From cd6afb281b31596c175ea3ee1d44f0efea25250f Mon Sep 17 00:00:00 2001
From: Jamie Iles <jamie@jamieiles.com>
Date: Fri, 10 Jun 2011 13:41:44 +0100
Subject: [PATCH] gpio: basic_mmio: add missing include of spinlock_types.h
include/linux/basic_mmio_gpio.h uses a spinlock_t without including any
of the spinlock headers resulting in this compiler warning.
include/linux/basic_mmio_gpio.h:51:2: error: expected specifier-qualifier-list before 'spinlock_t'
Explicitly include linux/spinlock_types.h to fix it.
Cc: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
---
include/linux/basic_mmio_gpio.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/basic_mmio_gpio.h b/include/linux/basic_mmio_gpio.h
index 1ae1271..98999cf 100644
--- a/include/linux/basic_mmio_gpio.h
+++ b/include/linux/basic_mmio_gpio.h
@@ -16,6 +16,7 @@
#include <linux/gpio.h>
#include <linux/types.h>
#include <linux/compiler.h>
+#include <linux/spinlock_types.h>
struct bgpio_pdata {
int base;
--
1.7.4.1
next prev parent reply other threads:[~2011-06-10 12:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 12:44 Jamie Iles
2011-06-10 12:48 ` Jamie Iles [this message]
2011-06-10 14:46 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110610124805.GN3711@pulham.picochip.com \
--to=jamie@jamieiles.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®