* [PATCH] gpio: basic_mmio: add missing include of spinlock_types.h
@ 2011-06-10 12:44 Jamie Iles
2011-06-10 12:48 ` Jamie Iles
0 siblings, 1 reply; 3+ messages in thread
From: Jamie Iles @ 2011-06-10 12:44 UTC (permalink / raw)
To: linux-kernel; +Cc: Jamie Iles, Grant Likely
include/linux/basic_mmio_gpio.h uses a spinlock_t without including any
of the spinlock headers resulting in this compiler warning.
include/linux/basic_mmio_gpio.h:51:2: error: expected specifier-qualifier-list before 'spinlock_t'
Explicitly include linux/spinlock_types.h to fix it.
Cc: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
---
include/linux/basic_mmio_gpio.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/basic_mmio_gpio.h b/include/linux/basic_mmio_gpio.h
index 1ae1271..0490e2e 100644
--- a/include/linux/basic_mmio_gpio.h
+++ b/include/linux/basic_mmio_gpio.h
@@ -16,6 +16,7 @@
#include <linux/gpio.h>
#include <linux/types.h>
#include <linux/compiler.h>
+#include <linux/spinlock.h>
struct bgpio_pdata {
int base;
--
1.7.4.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: basic_mmio: add missing include of spinlock_types.h
2011-06-10 12:44 [PATCH] gpio: basic_mmio: add missing include of spinlock_types.h Jamie Iles
@ 2011-06-10 12:48 ` Jamie Iles
2011-06-10 14:46 ` Grant Likely
0 siblings, 1 reply; 3+ messages in thread
From: Jamie Iles @ 2011-06-10 12:48 UTC (permalink / raw)
To: Jamie Iles; +Cc: linux-kernel, Grant Likely
On Fri, Jun 10, 2011 at 01:44:49PM +0100, Jamie Iles wrote:
> include/linux/basic_mmio_gpio.h uses a spinlock_t without including any
> of the spinlock headers resulting in this compiler warning.
>
> include/linux/basic_mmio_gpio.h:51:2: error: expected specifier-qualifier-list before 'spinlock_t'
>
> Explicitly include linux/spinlock_types.h to fix it.
Sorry, wrong patch. Here's the correct one.
Jamie
8<---
>From cd6afb281b31596c175ea3ee1d44f0efea25250f Mon Sep 17 00:00:00 2001
From: Jamie Iles <jamie@jamieiles.com>
Date: Fri, 10 Jun 2011 13:41:44 +0100
Subject: [PATCH] gpio: basic_mmio: add missing include of spinlock_types.h
include/linux/basic_mmio_gpio.h uses a spinlock_t without including any
of the spinlock headers resulting in this compiler warning.
include/linux/basic_mmio_gpio.h:51:2: error: expected specifier-qualifier-list before 'spinlock_t'
Explicitly include linux/spinlock_types.h to fix it.
Cc: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
---
include/linux/basic_mmio_gpio.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/basic_mmio_gpio.h b/include/linux/basic_mmio_gpio.h
index 1ae1271..98999cf 100644
--- a/include/linux/basic_mmio_gpio.h
+++ b/include/linux/basic_mmio_gpio.h
@@ -16,6 +16,7 @@
#include <linux/gpio.h>
#include <linux/types.h>
#include <linux/compiler.h>
+#include <linux/spinlock_types.h>
struct bgpio_pdata {
int base;
--
1.7.4.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: basic_mmio: add missing include of spinlock_types.h
2011-06-10 12:48 ` Jamie Iles
@ 2011-06-10 14:46 ` Grant Likely
0 siblings, 0 replies; 3+ messages in thread
From: Grant Likely @ 2011-06-10 14:46 UTC (permalink / raw)
To: Jamie Iles; +Cc: linux-kernel
On Fri, Jun 10, 2011 at 01:48:05PM +0100, Jamie Iles wrote:
> On Fri, Jun 10, 2011 at 01:44:49PM +0100, Jamie Iles wrote:
> > include/linux/basic_mmio_gpio.h uses a spinlock_t without including any
> > of the spinlock headers resulting in this compiler warning.
> >
> > include/linux/basic_mmio_gpio.h:51:2: error: expected specifier-qualifier-list before 'spinlock_t'
> >
> > Explicitly include linux/spinlock_types.h to fix it.
>
> Sorry, wrong patch. Here's the correct one.
>
> Jamie
Applied, thanks.
g.
>
> 8<---
>
> From cd6afb281b31596c175ea3ee1d44f0efea25250f Mon Sep 17 00:00:00 2001
> From: Jamie Iles <jamie@jamieiles.com>
> Date: Fri, 10 Jun 2011 13:41:44 +0100
> Subject: [PATCH] gpio: basic_mmio: add missing include of spinlock_types.h
>
> include/linux/basic_mmio_gpio.h uses a spinlock_t without including any
> of the spinlock headers resulting in this compiler warning.
>
> include/linux/basic_mmio_gpio.h:51:2: error: expected specifier-qualifier-list before 'spinlock_t'
>
> Explicitly include linux/spinlock_types.h to fix it.
>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Signed-off-by: Jamie Iles <jamie@jamieiles.com>
> ---
> include/linux/basic_mmio_gpio.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/basic_mmio_gpio.h b/include/linux/basic_mmio_gpio.h
> index 1ae1271..98999cf 100644
> --- a/include/linux/basic_mmio_gpio.h
> +++ b/include/linux/basic_mmio_gpio.h
> @@ -16,6 +16,7 @@
> #include <linux/gpio.h>
> #include <linux/types.h>
> #include <linux/compiler.h>
> +#include <linux/spinlock_types.h>
>
> struct bgpio_pdata {
> int base;
> --
> 1.7.4.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-10 14:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-10 12:44 [PATCH] gpio: basic_mmio: add missing include of spinlock_types.h Jamie Iles
2011-06-10 12:48 ` Jamie Iles
2011-06-10 14:46 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®