From: Dan Carpenter <error27@gmail.com>
To: Kirill Smelkov <kirr@mns.spb.ru>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
devel@driverdev.osuosl.org,
Tomas Winkler <tomas.winkler@intel.com>,
Mike Thomas <rmthomas@sciolus.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] staging/easycap: Fix thinko in "bars" module option description
Date: Mon, 13 Jun 2011 15:27:17 +0300 [thread overview]
Message-ID: <20110613122717.GF3583@shale.localdomain> (raw)
In-Reply-To: <14c0e4d0bb7ef1a05b9dcc14b2b51c706f844655.1307967011.git.kirr@mns.spb.ru>
On Mon, Jun 13, 2011 at 04:18:29PM +0400, Kirill Smelkov wrote:
> Both bars=0 and bars=1 were described as meaning to display bars on
> signal lost. Actually bars=1 means "display bars", but bars=0 means
> display raw source as is (usually black screen).
Your description up here is much better than the one in the README.
Maybe just include yours and delete the original.
regards,
dan carpenter
>
> Cc: Tomas Winkler <tomas.winkler@intel.com>
> Cc: Mike Thomas <rmthomas@sciolus.org>
> Signed-off-by: Kirill Smelkov <kirr@mns.spb.ru>
> ---
> drivers/staging/easycap/README | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/easycap/README b/drivers/staging/easycap/README
> index 16b8264..cd55eea 100644
> --- a/drivers/staging/easycap/README
> +++ b/drivers/staging/easycap/README
> @@ -60,7 +60,7 @@ Three module parameters are defined:
>
> debug the easycap module is configured at diagnostic level n (0 to 9)
> gain audio gain level n (0 to 31, default is 16)
> -bars 0 => testcard bars when incoming video signal is lost
> +bars 0 => no testcard bars when incoming video signal is lost
> 1 => testcard bars when incoming video signal is lost (default)
>
>
> --
> 1.7.6.rc1
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
next prev parent reply other threads:[~2011-06-13 12:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 12:18 [PATCH 0/5] staging/easycap cleanups + fix Kirill Smelkov
2011-06-13 12:18 ` [PATCH 1/5] staging/easycap: Kill leftover build options in readme Kirill Smelkov
2011-06-13 12:24 ` Winkler, Tomas
2011-06-13 12:18 ` [PATCH 2/5] staging/easycap: Fix thinko in "bars" module option description Kirill Smelkov
2011-06-13 12:25 ` Winkler, Tomas
2011-06-13 12:27 ` Dan Carpenter [this message]
2011-06-14 16:46 ` Kirill Smelkov
2011-06-14 17:16 ` Dan Carpenter
2011-06-29 8:35 ` Kirill Smelkov
2011-06-29 8:37 ` Winkler, Tomas
2011-06-13 12:18 ` [PATCH 3/5] staging/easycap: There is no need to support V4L1 ioctls Kirill Smelkov
2011-06-13 12:26 ` Winkler, Tomas
2011-06-13 12:18 ` [PATCH 4/5] staging/easycap: PAGE_SIZE is always defined Kirill Smelkov
2011-06-13 12:26 ` Winkler, Tomas
2011-06-13 12:18 ` [PATCH 5/5] staging/easycap: Fix bytesperline calculation Kirill Smelkov
2011-06-13 12:36 ` Dan Carpenter
2011-06-14 16:37 ` Kirill Smelkov
2011-06-14 21:01 ` Winkler, Tomas
2011-06-29 8:42 ` Kirill Smelkov
2011-06-13 13:23 ` Winkler, Tomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110613122717.GF3583@shale.localdomain \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=kirr@mns.spb.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=rmthomas@sciolus.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®