From: Dan Carpenter <error27@gmail.com>
To: Kirill Smelkov <kirr@mns.spb.ru>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
devel@driverdev.osuosl.org,
Tomas Winkler <tomas.winkler@intel.com>,
Mike Thomas <rmthomas@sciolus.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] staging/easycap: Fix bytesperline calculation
Date: Mon, 13 Jun 2011 15:36:59 +0300 [thread overview]
Message-ID: <20110613123659.GG3583@shale.localdomain> (raw)
In-Reply-To: <bcbeb6b7c5ab7624ea59b072f74347fa8e6a6350.1307967011.git.kirr@mns.spb.ru>
It warms my heart to see a beautiful commit message like that,
complete with diagrams. :)
>
> P.S. why at all we use those mask/shifts? Why not use bitfields?
Because this is crap code from the staging dir.
regards,
dan carpenter
next prev parent reply other threads:[~2011-06-13 12:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 12:18 [PATCH 0/5] staging/easycap cleanups + fix Kirill Smelkov
2011-06-13 12:18 ` [PATCH 1/5] staging/easycap: Kill leftover build options in readme Kirill Smelkov
2011-06-13 12:24 ` Winkler, Tomas
2011-06-13 12:18 ` [PATCH 2/5] staging/easycap: Fix thinko in "bars" module option description Kirill Smelkov
2011-06-13 12:25 ` Winkler, Tomas
2011-06-13 12:27 ` Dan Carpenter
2011-06-14 16:46 ` Kirill Smelkov
2011-06-14 17:16 ` Dan Carpenter
2011-06-29 8:35 ` Kirill Smelkov
2011-06-29 8:37 ` Winkler, Tomas
2011-06-13 12:18 ` [PATCH 3/5] staging/easycap: There is no need to support V4L1 ioctls Kirill Smelkov
2011-06-13 12:26 ` Winkler, Tomas
2011-06-13 12:18 ` [PATCH 4/5] staging/easycap: PAGE_SIZE is always defined Kirill Smelkov
2011-06-13 12:26 ` Winkler, Tomas
2011-06-13 12:18 ` [PATCH 5/5] staging/easycap: Fix bytesperline calculation Kirill Smelkov
2011-06-13 12:36 ` Dan Carpenter [this message]
2011-06-14 16:37 ` Kirill Smelkov
2011-06-14 21:01 ` Winkler, Tomas
2011-06-29 8:42 ` Kirill Smelkov
2011-06-13 13:23 ` Winkler, Tomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110613123659.GG3583@shale.localdomain \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=kirr@mns.spb.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=rmthomas@sciolus.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®