From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Dirk Gouders <gouders@et.bocholt.fh-gelsenkirchen.de>
Cc: linux-kernel@vger.kernel.org, Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [2.6.39] drm/i915: blank screen on Lenovo Ideapad U160
Date: Wed, 15 Jun 2011 15:07:37 -0700 [thread overview]
Message-ID: <20110615150737.79cd5de7@jbarnes-desktop> (raw)
In-Reply-To: <giei2ulpl1.fsf@mx10.gouders.net>
On Thu, 16 Jun 2011 00:03:38 +0200
Dirk Gouders <gouders@et.bocholt.fh-gelsenkirchen.de> wrote:
> Jesse Barnes <jbarnes@virtuousgeek.org> writes:
>
> > Oh is this not an LVDS panel? I'm curious which of the port disables
> > is at fault in your config then. If you have an eDP panel, it would
> > likely be the PCH_DP_D write. It could be a side effect of the
> > PANEL_UNLOCK_REGS write as well though, can you try commenting each of
> > those out?
>
> Yes, you are right. Commenting out a single line helps:
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 81a9059..ed95cbf 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -1356,7 +1356,7 @@ static void intel_disable_pch_ports(struct drm_i915_private *dev_priv,
> u32 reg, val;
>
> val = I915_READ(PCH_PP_CONTROL);
> - I915_WRITE(PCH_PP_CONTROL, val | PANEL_UNLOCK_REGS);
> + //I915_WRITE(PCH_PP_CONTROL, val | PANEL_UNLOCK_REGS);
>
> disable_pch_dp(dev_priv, pipe, PCH_DP_B);
> disable_pch_dp(dev_priv, pipe, PCH_DP_C);
Ok interesting, that means one of the locked regs we're trying to write
later is the real culprit for this issue... those include the LVDS reg
and the panel timing regs. I'll see if I can figure out which one
might be the problem.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2011-06-15 22:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 17:57 [3.0-rc1] i915: " Dirk Gouders
2011-05-31 18:08 ` Robert P. J. Day
2011-05-31 18:37 ` Dirk Gouders
2011-05-31 19:29 ` Dirk Gouders
2011-06-13 21:21 ` [2.6.39] drm/i915: " Dirk Gouders
2011-06-15 18:59 ` Jesse Barnes
2011-06-15 21:29 ` Dirk Gouders
2011-06-15 21:41 ` Jesse Barnes
2011-06-15 22:03 ` Dirk Gouders
2011-06-15 22:07 ` Jesse Barnes [this message]
2011-06-16 7:38 ` Dirk Gouders
2011-06-16 11:49 ` Dirk Gouders
2011-06-16 16:40 ` Jesse Barnes
2011-06-16 17:54 ` Dirk Gouders
2011-06-16 18:41 ` Jesse Barnes
2011-06-18 11:11 ` Dirk Gouders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110615150737.79cd5de7@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=chris@chris-wilson.co.uk \
--cc=gouders@et.bocholt.fh-gelsenkirchen.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome