mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Dirk Gouders <gouders@et.bocholt.fh-gelsenkirchen.de>
Cc: linux-kernel@vger.kernel.org, Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [2.6.39] drm/i915: blank screen on Lenovo Ideapad U160
Date: Thu, 16 Jun 2011 11:41:46 -0700	[thread overview]
Message-ID: <20110616114146.4662ea2f@jbarnes-desktop> (raw)
In-Reply-To: <gisjr9ll0j.fsf@mx10.gouders.net>

On Thu, 16 Jun 2011 19:54:36 +0200
Dirk Gouders <gouders@et.bocholt.fh-gelsenkirchen.de> wrote:

> Jesse Barnes <jbarnes@virtuousgeek.org> writes:
> 
> > On Thu, 16 Jun 2011 13:49:11 +0200
> > Dirk Gouders <gouders@et.bocholt.fh-gelsenkirchen.de> wrote:
> >
> >> Some redundant information, but if I change one line at another place
> >> in the i915 code (whithout the above modification) the result is more
> >> satisfactory on my machine, because in that case the display even works
> >> after I close and reopen the lid:
> >> 
> >> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> >> index 927442a..ebb67ae 100644
> >> --- a/drivers/gpu/drm/i915/intel_bios.c
> >> +++ b/drivers/gpu/drm/i915/intel_bios.c
> >> @@ -267,7 +267,7 @@ static int intel_bios_ssc_frequency(struct drm_device *dev,
> >>         case 4:
> >>                 return alternate ? 100 : 96;
> >>         default:
> >> -               return alternate ? 100 : 120;
> >> +               return alternate ? 120 : 100;
> >>         }
> >>  }
> >
> > Does your machine also work if you set the lvds_use_ssc param to 0?
> 
> Yes, that works!
> I undid all modifications, compiled the i915 driver as a module (I am
> not sure if that is necessary) und used i915.lvds_use_ssc=0 as a
> further bootparameter, I will attach the dmesg output.
> 
> Would you say "This problem was just a case of wrong parameter usage",
> then?

No, we should be parsing the VBT differently in your case it appears.
But the simple change above will break other platforms, so it's
possible we're missing a VBT format change and need to parse it
differently depending on the version.

-- 
Jesse Barnes, Intel Open Source Technology Center

  reply	other threads:[~2011-06-16 18:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-31 17:57 [3.0-rc1] i915: " Dirk Gouders
2011-05-31 18:08 ` Robert P. J. Day
2011-05-31 18:37   ` Dirk Gouders
2011-05-31 19:29     ` Dirk Gouders
2011-06-13 21:21       ` [2.6.39] drm/i915: " Dirk Gouders
2011-06-15 18:59         ` Jesse Barnes
2011-06-15 21:29           ` Dirk Gouders
2011-06-15 21:41             ` Jesse Barnes
2011-06-15 22:03               ` Dirk Gouders
2011-06-15 22:07                 ` Jesse Barnes
2011-06-16  7:38                   ` Dirk Gouders
2011-06-16 11:49                     ` Dirk Gouders
2011-06-16 16:40                       ` Jesse Barnes
2011-06-16 17:54                         ` Dirk Gouders
2011-06-16 18:41                           ` Jesse Barnes [this message]
2011-06-18 11:11                             ` Dirk Gouders

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110616114146.4662ea2f@jbarnes-desktop \
    --to=jbarnes@virtuousgeek.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=gouders@et.bocholt.fh-gelsenkirchen.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome