Re: fs/exec.c: use BUILD_BUG_ON for VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP

[Randy Dunlap <randy.dunlap@oracle.com>]

On Thu, 16 Jun 2011 03:59:03 GMT Linux Kernel Mailing List wrote:

> Gitweb:     http://git.kernel.org/linus/7f81c8890c15a10f5220bebae3b6dfae4961962a
> Commit:     7f81c8890c15a10f5220bebae3b6dfae4961962a
> Parent:     b0825ee3a8c570df4873ee397fa453e67fdad5d7
> Author:     Michal Hocko <mhocko@suse.cz>
> AuthorDate: Wed Jun 15 15:08:11 2011 -0700
> Committer:  Linus Torvalds <torvalds@linux-foundation.org>
> CommitDate: Wed Jun 15 20:03:59 2011 -0700
> 
>     fs/exec.c: use BUILD_BUG_ON for VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP
>     
>     Commit a8bef8ff6ea1 ("mm: migration: avoid race between shift_arg_pages()
>     and rmap_walk() during migration by not migrating temporary stacks")
>     introduced a BUG_ON() to ensure that VM_STACK_FLAGS and
>     VM_STACK_INCOMPLETE_SETUP do not overlap.  The check is a compile time
>     one, so BUILD_BUG_ON is more appropriate.
>     
>     Signed-off-by: Michal Hocko <mhocko@suse.cz>
>     Cc: Mel Gorman <mel@csn.ul.ie>
>     Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

fwiw, I just reported that this causes a build error in UML on x86_64
in mmotm-2011-06-15:

When building UML for x86_64 (defconfig), I get:

fs/built-in.o: In function `__bprm_mm_init':
mmotm-2011-0615-1656/fs/exec.c:280: undefined reference to `__build_bug_on_failed'


> ---
>  fs/exec.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/exec.c b/fs/exec.c
> index 97e0d52..b54f74f 100644
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -277,7 +277,7 @@ static int __bprm_mm_init(struct linux_binprm *bprm)
>  	 * use STACK_TOP because that can depend on attributes which aren't
>  	 * configured yet.
>  	 */
> -	BUG_ON(VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP);
> +	BUILD_BUG_ON(VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP);
>  	vma->vm_end = STACK_TOP_MAX;
>  	vma->vm_start = vma->vm_end - PAGE_SIZE;
>  	vma->vm_flags = VM_STACK_FLAGS | VM_STACK_INCOMPLETE_SETUP;
> --


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***