mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Randy Dunlap <randy.dunlap@oracle.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Michal Hocko <mhocko@suse.cz>
Subject: Re: fs/exec.c: use BUILD_BUG_ON for VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP
Date: Thu, 16 Jun 2011 11:36:32 +0200	[thread overview]
Message-ID: <c0f2919da04b0e601dc84ce31f1c9b81@radon2.swed.at> (raw)
In-Reply-To: <20110615215207.ba7a0386.akpm@linux-foundation.org>

On Wed, 15 Jun 2011 21:52:07 -0700, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Wed, 15 Jun 2011 21:45:00 -0700 Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> 
>> On Wed, Jun 15, 2011 at 9:35 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>> >
>> > fwiw, I just reported that this causes a build error in UML on x86_64
>> > in mmotm-2011-06-15:
>>
>> Gaah. That sounds really familiar. Have we done this same mistake once
>> before already, or is it just deja-vu for some other reason.
>>
>> On x86-64 UML, we have
>>
>>   #define VM_STACK_DEFAULT_FLAGS vm_stack_flags
>>
>> so VM_STACK_FLAGS ends up not being a constant, even though it really
>> looks like one.
>>
>> UML is _really_ confused in this area, btw. It seems to re-define that
>> thing if TIF_IA32 is defined. That's some crazy stuff. Doesn't the
>> compiler warn about it?
>>
>> I guess I should just revert that commit, though. Even if it does seem
>> to be the case that UML is just being crazy. Andrew?
>>
> 
> Sure, it was just a tiny optimization.
> 
> We can bring it back if Richard feels like decrazyifying UML ;)
> 

I'll look at this.
BTW: 64bit UML is really crazy. :P

Thanks,
//richard

      parent reply	other threads:[~2011-06-16  9:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201106160359.p5G3x3j4020081@hera.kernel.org>
2011-06-16  4:35 ` Randy Dunlap
2011-06-16  4:45   ` Linus Torvalds
2011-06-16  4:52     ` Andrew Morton
2011-06-16  6:35       ` Michal Hocko
2011-06-16  9:36       ` Richard Weinberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0f2919da04b0e601dc84ce31f1c9b81@radon2.swed.at \
    --to=richard@nod.at \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@suse.cz \
    --cc=randy.dunlap@oracle.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®