From: David Miller <davem@davemloft.net>
To: jasowang@redhat.com
Cc: arnd@arndb.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] macvtap: remove wrong sock_put() in macvtap_put_queue()
Date: Thu, 16 Jun 2011 22:58:25 -0400 (EDT) [thread overview]
Message-ID: <20110616.225825.127982592225091945.davem@davemloft.net> (raw)
In-Reply-To: <1307934919-4189-1-git-send-email-jasowang@redhat.com>
From: Jason Wang <jasowang@redhat.com>
Date: Mon, 13 Jun 2011 11:15:19 +0800
> The calling of sock_put() should be delayed after synchronize_rcu(),
> otherwise inconsist data may be seen during packets transmitting.
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
You're leaking sockets now.
This function has to release the socket twice if there is
a non-NULL vlan assigned to the queue.
Now you're only doing it once in that situation.
Which probably fixes your crash, but adds a socket leak.
prev parent reply other threads:[~2011-06-17 2:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 3:15 Jason Wang
2011-06-17 2:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110616.225825.127982592225091945.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®