Re: [PATCH] TMPFS: Expand "help" to explain value of TMPFS_POSIX_ACL

[Randy Dunlap <rdunlap@xenotime.net>]

On Sat, 18 Jun 2011 07:45:35 -0400 (EDT) Robert P. J. Day wrote:

> 
> Expand the fs/Kconfig "help" info to clarify why it's a bad idea to
> deselect the TMPFS_POSIX_ACL config variable.
> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> 
> ---
> 
> diff --git a/fs/Kconfig b/fs/Kconfig
> index 19891aa..4217543 100644
> --- a/fs/Kconfig
> +++ b/fs/Kconfig
> @@ -127,14 +127,20 @@ config TMPFS_POSIX_ACL
>  	select TMPFS_XATTR
>  	select GENERIC_ACL
>  	help
> -	  POSIX Access Control Lists (ACLs) support permissions for users and
> -	  groups beyond the owner/group/world scheme.
> +	  POSIX Access Control Lists (ACLs) support additional access rights
> +	  for users and groups beyond the standard owner/group/world scheme,
> +	  and this option selects support for ACLs specifically for tmpfs
> +	  filesystems.
> +
> +	  If you've selected TMPFS, you almost certainly want this option
> +	  as well since a number of user space features (ie., ALSA sound)

	                                                 e.g.,
?

Otherwise, looks good to me.
Thanks.

> +	  require POSIX ACL support under /dev to work properly.  In other
> +	  words, if you're not sure and you have no *compelling* reason to
> +	  deselect this feature, say Y.
> 
>  	  To learn more about Access Control Lists, visit the POSIX ACLs for
>  	  Linux website <http://acl.bestbits.at/>.
> 
> -	  If you don't know what Access Control Lists are, say N.
> -
>  config TMPFS_XATTR
>  	bool "Tmpfs extended attributes"
>  	depends on TMPFS


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***