Re: [PATCH] TMPFS: Expand "help" to explain value of TMPFS_POSIX_ACL

[Randy Dunlap <rdunlap@xenotime.net>]

On Sat, 18 Jun 2011 11:03:35 -0400 (EDT) Robert P. J. Day wrote:

> On Sat, 18 Jun 2011, Randy Dunlap wrote:
> 
> > On Sat, 18 Jun 2011 07:45:35 -0400 (EDT) Robert P. J. Day wrote:
> >
> > >
> > > Expand the fs/Kconfig "help" info to clarify why it's a bad idea to
> > > deselect the TMPFS_POSIX_ACL config variable.
> > >
> > > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> > >
> > > ---
> > >
> > > diff --git a/fs/Kconfig b/fs/Kconfig
> > > index 19891aa..4217543 100644
> > > --- a/fs/Kconfig
> > > +++ b/fs/Kconfig
> > > @@ -127,14 +127,20 @@ config TMPFS_POSIX_ACL
> > >  	select TMPFS_XATTR
> > >  	select GENERIC_ACL
> > >  	help
> > > -	  POSIX Access Control Lists (ACLs) support permissions for users and
> > > -	  groups beyond the owner/group/world scheme.
> > > +	  POSIX Access Control Lists (ACLs) support additional access rights
> > > +	  for users and groups beyond the standard owner/group/world scheme,
> > > +	  and this option selects support for ACLs specifically for tmpfs
> > > +	  filesystems.
> > > +
> > > +	  If you've selected TMPFS, you almost certainly want this option
> > > +	  as well since a number of user space features (ie., ALSA sound)
> >
> > 	                                                 e.g.,
> > ?
> >
> > Otherwise, looks good to me.
> > Thanks.
> 
>   oops, i can submit a V2 patch that changes that.  or you can hack
> what i submitted.  either way works for me.

Please submit a v2 patch and cc: akpm on it since he will probably merge it.

thanks,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***