mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Denys Vlasenko <vda.linux@googlemail.com>
Cc: oleg@redhat.com, jan.kratochvil@redhat.com,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	akpm@linux-foundation.org, indan@nul.nu, bdonlan@gmail.com,
	pedro@codesourcery.com
Subject: Re: [PATCH 2/5] ptrace: implement PTRACE_SEIZE
Date: Sat, 18 Jun 2011 10:35:59 +0200	[thread overview]
Message-ID: <20110618083559.GK2611@htj.dyndns.org> (raw)
In-Reply-To: <201106180959.38847.vda.linux@googlemail.com>

Hello,

On Sat, Jun 18, 2011 at 09:59:38AM +0200, Denys Vlasenko wrote:
> ...unless we plan to introduce PTRACE_O_TRACESTOP (with value 0x00000080)
> which enables PTRACE_INTERRUPT and stop notifications independently
> of PTRACE_SEIZE. Which would be very useful for e.g. strace.

I know you're a big fan of those option flags but I don't really see
the added value in making these behaviors optional rather than keeping
things backward compatible - ie. introducing new event needed to be
gated somehow so the O flags but SEIZE itself serves as a big gate
anyway so I don't see much point in introducing multiple selectable
behaviors.  It's not like PTRACE_O_TRACESTOP is gonna make anything
drastically easier or reduce significant amount of overhead.

Thanks.

-- 
tejun

  reply	other threads:[~2011-06-18  8:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14  9:20 [PATCHSET ptrace] ptrace: implement PTRACE_SEIZE/INTERRUPT and group stop notification, take#5 Tejun Heo
2011-06-14  9:20 ` [PATCH 1/5] job control: introduce JOBCTL_TRAP_STOP and use it for group stop trap Tejun Heo
2011-06-14  9:20 ` [PATCH 2/5] ptrace: implement PTRACE_SEIZE Tejun Heo
2011-06-18  7:55   ` Denys Vlasenko
2011-06-18  7:59     ` Denys Vlasenko
2011-06-18  8:35       ` Tejun Heo [this message]
2011-06-18  8:57         ` Denys Vlasenko
2011-06-18  9:04           ` Tejun Heo
2011-06-18  8:30     ` Tejun Heo
2011-06-18  8:58       ` Denys Vlasenko
2011-06-14  9:20 ` [PATCH 3/5] ptrace: implement PTRACE_INTERRUPT Tejun Heo
2011-06-14  9:20 ` [PATCH 4/5] ptrace: implement TRAP_NOTIFY and use it for group stop events Tejun Heo
2011-06-16 19:51   ` Oleg Nesterov
2011-06-17 15:12     ` Tejun Heo
2011-06-17 18:31       ` Oleg Nesterov
2011-06-14  9:20 ` [PATCH 5/5] ptrace: implement PTRACE_LISTEN Tejun Heo
2011-09-23 11:17   ` Matt Fleming
2011-09-23 12:26     ` Oleg Nesterov
2011-06-16 19:44 ` [PATCHSET ptrace] ptrace: implement PTRACE_SEIZE/INTERRUPT and group stop notification, take#5 Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110618083559.GK2611@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=bdonlan@gmail.com \
    --cc=indan@nul.nu \
    --cc=jan.kratochvil@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=pedro@codesourcery.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vda.linux@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®