From: Tejun Heo <tj@kernel.org>
To: Denys Vlasenko <vda.linux@googlemail.com>
Cc: oleg@redhat.com, jan.kratochvil@redhat.com,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, indan@nul.nu, bdonlan@gmail.com,
pedro@codesourcery.com
Subject: Re: [PATCH 2/5] ptrace: implement PTRACE_SEIZE
Date: Sat, 18 Jun 2011 11:04:31 +0200 [thread overview]
Message-ID: <20110618090431.GL2611@htj.dyndns.org> (raw)
In-Reply-To: <201106181057.02477.vda.linux@googlemail.com>
Hello,
On Sat, Jun 18, 2011 at 10:57:02AM +0200, Denys Vlasenko wrote:
> I explained this already. strace code is a bit complex, and adding
> more complexity so that it uses PTRACE_SEIZE if available, but PTRACE_ATTACH
> if it is not, will add some PITA.
>
> Considering that strace does not want PTRACE_SEIZE per se, it only wants
> to have a way to properly see and handle group stops, having an option
> to enable *only that functonality* without having to use PTRACE_SEIZE
> will be useful for strace.
I understand that it would make strace's life somewhat easier but
don't agree the difference is significant enough to justify
introducing more options. We're talking about small number of well
defined behaviors. Yes, it wouldn't be as simple as adding several
liners during initialization but that doesn't warrant extra kernel
features and differing behaviors which, I think, in the long run, make
things much more complicated (not complex) than necessary.
Thanks.
--
tejun
next prev parent reply other threads:[~2011-06-18 9:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 9:20 [PATCHSET ptrace] ptrace: implement PTRACE_SEIZE/INTERRUPT and group stop notification, take#5 Tejun Heo
2011-06-14 9:20 ` [PATCH 1/5] job control: introduce JOBCTL_TRAP_STOP and use it for group stop trap Tejun Heo
2011-06-14 9:20 ` [PATCH 2/5] ptrace: implement PTRACE_SEIZE Tejun Heo
2011-06-18 7:55 ` Denys Vlasenko
2011-06-18 7:59 ` Denys Vlasenko
2011-06-18 8:35 ` Tejun Heo
2011-06-18 8:57 ` Denys Vlasenko
2011-06-18 9:04 ` Tejun Heo [this message]
2011-06-18 8:30 ` Tejun Heo
2011-06-18 8:58 ` Denys Vlasenko
2011-06-14 9:20 ` [PATCH 3/5] ptrace: implement PTRACE_INTERRUPT Tejun Heo
2011-06-14 9:20 ` [PATCH 4/5] ptrace: implement TRAP_NOTIFY and use it for group stop events Tejun Heo
2011-06-16 19:51 ` Oleg Nesterov
2011-06-17 15:12 ` Tejun Heo
2011-06-17 18:31 ` Oleg Nesterov
2011-06-14 9:20 ` [PATCH 5/5] ptrace: implement PTRACE_LISTEN Tejun Heo
2011-09-23 11:17 ` Matt Fleming
2011-09-23 12:26 ` Oleg Nesterov
2011-06-16 19:44 ` [PATCHSET ptrace] ptrace: implement PTRACE_SEIZE/INTERRUPT and group stop notification, take#5 Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110618090431.GL2611@htj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bdonlan@gmail.com \
--cc=indan@nul.nu \
--cc=jan.kratochvil@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=pedro@codesourcery.com \
--cc=torvalds@linux-foundation.org \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®