From: David Miller <davem@davemloft.net>
To: andi@firstfloor.org
Cc: torvalds@linux-foundation.org, mroos@linux.ee,
linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: reorganized struct inode results in unaligned accesses
Date: Sun, 19 Jun 2011 16:01:50 -0700 (PDT) [thread overview]
Message-ID: <20110619.160150.1199476848151993579.davem@davemloft.net> (raw)
In-Reply-To: <m2boxtfo0d.fsf@firstfloor.org>
From: Andi Kleen <andi@firstfloor.org>
Date: Sun, 19 Jun 2011 15:35:30 -0700
> Linus Torvalds <torvalds@linux-foundation.org> writes:
>>
>> Dang. I guess it needs to be made "unsigned long" again. Which is a
>> shame, because we only use a couple of bits from there, and "struct
>> inode" really is much too big already.
>
> In the past it was usually enough to just align it to alignof(unsigned
> long), not actually make it long. struct page went through this
> a long time ago.
Hmmm, can this scheme actually work out properly on both big and
little endian? Because endianness determines whether the bits start
in the "lower addressed" 32-bit word or the "higher addressed" 32-bit
word.
If this trick is being attempted elsewhere, I think it could perhaps
account for some strange bugs :-)
next prev parent reply other threads:[~2011-06-19 23:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-19 16:33 Meelis Roos
2011-06-19 16:51 ` Linus Torvalds
2011-06-19 22:35 ` Andi Kleen
2011-06-19 23:01 ` David Miller [this message]
2011-06-19 23:14 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110619.160150.1199476848151993579.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@linux.ee \
--cc=sparclinux@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®