From: Meelis Roos <mroos@linux.ee>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
sparclinux@vger.kernel.org
Subject: reorganized struct inode results in unaligned accesses
Date: Sun, 19 Jun 2011 19:33:08 +0300 (EEST) [thread overview]
Message-ID: <alpine.SOC.1.00.1106191927250.4844@math.ut.ee> (raw)
A week ago I noticed that in 3.0.0-rc3, sparc64 machines log a lot of
unaligned accesses in different vfs functions in dmesg. I reported but
obviously not well enough. Today I had a look at it and found the
reason.
Commit 13e12d14e2dccc7995b8f15a5678a338ab4e6a8c (vfs: reorganize 'struct
inode' layout a bit) changes i_state to be unsigned int instead of
unsigned long. This is the cause of unaligned accesses on sparc64 and
maybe others. Changing it back to unsigned long fixes the warnings but I
did not look at the layout of the resulting struct - might leave a hole
there.
--
Meelis Roos (mroos@linux.ee)
next reply other threads:[~2011-06-19 16:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-19 16:33 Meelis Roos [this message]
2011-06-19 16:51 ` Linus Torvalds
2011-06-19 22:35 ` Andi Kleen
2011-06-19 23:01 ` David Miller
2011-06-19 23:14 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.SOC.1.00.1106191927250.4844@math.ut.ee \
--to=mroos@linux.ee \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®