mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH][Trivial]: ipv4, ping: Remove duplicate icmp.h include
@ 2011-06-20  8:31 Jesper Juhl
  2011-06-20 20:05 ` David Miller
  0 siblings, 1 reply; 5+ messages in thread
From: Jesper Juhl @ 2011-06-20  8:31 UTC (permalink / raw)
  To: netdev; +Cc: Vasiliy Kulikov, linux-kernel, David S. Miller, trivial

Remove the duplicate inclusion of net/icmp.h from net/ipv4/ping.c

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
 ping.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c
index 9aaa671..39b403f 100644
--- a/net/ipv4/ping.c
+++ b/net/ipv4/ping.c
@@ -41,7 +41,6 @@
 #include <linux/proc_fs.h>
 #include <net/sock.h>
 #include <net/ping.h>
-#include <net/icmp.h>
 #include <net/udp.h>
 #include <net/route.h>
 #include <net/inet_common.h>

-- 
Jesper Juhl <jj@chaosbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH][Trivial]: ipv4, ping: Remove duplicate icmp.h include
  2011-06-20  8:31 [PATCH][Trivial]: ipv4, ping: Remove duplicate icmp.h include Jesper Juhl
@ 2011-06-20 20:05 ` David Miller
  2011-06-20 20:50   ` Vitaliy Ivanov
  0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2011-06-20 20:05 UTC (permalink / raw)
  To: jj; +Cc: netdev, segoon, linux-kernel, trivial

From: Jesper Juhl <jj@chaosbits.net>
Date: Mon, 20 Jun 2011 10:31:20 +0200 (CEST)

> Remove the duplicate inclusion of net/icmp.h from net/ipv4/ping.c
> 
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>

Applied.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH][Trivial]: ipv4, ping: Remove duplicate icmp.h include
  2011-06-20 20:05 ` David Miller
@ 2011-06-20 20:50   ` Vitaliy Ivanov
  2011-06-20 20:52     ` David Miller
  2011-06-20 20:53     ` Jiri Kosina
  0 siblings, 2 replies; 5+ messages in thread
From: Vitaliy Ivanov @ 2011-06-20 20:50 UTC (permalink / raw)
  To: David Miller; +Cc: jj, netdev, segoon, linux-kernel, trivial

David,

It's already in Jiri's trivial tree.

Vitaliy

Sent from my iPhone

On Jun 20, 2011, at 23:05, David Miller <davem@davemloft.net> wrote:

> From: Jesper Juhl <jj@chaosbits.net>
> Date: Mon, 20 Jun 2011 10:31:20 +0200 (CEST)
>
>> Remove the duplicate inclusion of net/icmp.h from net/ipv4/ping.c
>>
>> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
>
> Applied.
> --
> To unsubscribe from this list: send the line "unsubscribe linux- 
> kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH][Trivial]: ipv4, ping: Remove duplicate icmp.h include
  2011-06-20 20:50   ` Vitaliy Ivanov
@ 2011-06-20 20:52     ` David Miller
  2011-06-20 20:53     ` Jiri Kosina
  1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2011-06-20 20:52 UTC (permalink / raw)
  To: vitalivanov; +Cc: jj, netdev, segoon, linux-kernel, trivial

From: Vitaliy Ivanov <vitalivanov@gmail.com>
Date: Mon, 20 Jun 2011 23:50:38 +0300

> It's already in Jiri's trivial tree.

And now it's in mine, no harm :-)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH][Trivial]: ipv4, ping: Remove duplicate icmp.h include
  2011-06-20 20:50   ` Vitaliy Ivanov
  2011-06-20 20:52     ` David Miller
@ 2011-06-20 20:53     ` Jiri Kosina
  1 sibling, 0 replies; 5+ messages in thread
From: Jiri Kosina @ 2011-06-20 20:53 UTC (permalink / raw)
  To: Vitaliy Ivanov; +Cc: David Miller, jj, netdev, segoon, linux-kernel

On Mon, 20 Jun 2011, Vitaliy Ivanov wrote:

> David,
> 
> It's already in Jiri's trivial tree.

Yeah, it's in my tree as part of larger tree-wide patch.

But that's not a problem really, git can handle that just perfectly well.

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-06-20 20:53 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-20  8:31 [PATCH][Trivial]: ipv4, ping: Remove duplicate icmp.h include Jesper Juhl
2011-06-20 20:05 ` David Miller
2011-06-20 20:50   ` Vitaliy Ivanov
2011-06-20 20:52     ` David Miller
2011-06-20 20:53     ` Jiri Kosina

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®