mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Denys Vlasenko <vda.linux@googlemail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ptrace: make former thread ID available via PTRACE_GETEVENTMSG after PTRACE_EVENT_EXEC stop (v.2)
Date: Tue, 28 Jun 2011 10:25:12 +0200	[thread overview]
Message-ID: <20110628082512.GA3386@htj.dyndns.org> (raw)
In-Reply-To: <20110627151827.GA6223@redhat.com>

Hello,

On Mon, Jun 27, 2011 at 05:18:27PM +0200, Oleg Nesterov wrote:
> > and the only way to discover would be either comparing kernel
> > version or actually trying it - both aren't too nice.
> 
> Fortunately, currently tracehook_report_exec() zeroes ->ptrace_message.
> At least this means that anything != 0 means it works.

Yeah, but that's a pretty silly way to do it.  If we make it depend on
PT_SEIZED, we can simply say "if seized, EXEC reports..." but as it
currently stands, it would go like "If the message is non-zero on
EXEC, it indicates...  This behavior is valid since kernel version
x.x.x".  Maybe adding a guarantee that PTRACE_SEIZE capable kernel
always reports the old pid on EXEC but that would still seem
unnecessarily complicated.  It isn't a bug fix.  I don't see much
point in introducing new behavior separately.

Thanks.

-- 
tejun

  reply	other threads:[~2011-06-28  8:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-26 19:08 Denys Vlasenko
2011-06-26 20:04 ` Oleg Nesterov
2011-06-27  8:11   ` Tejun Heo
2011-06-27 13:47     ` Oleg Nesterov
2011-06-27 13:52       ` Tejun Heo
2011-06-27 15:18         ` Oleg Nesterov
2011-06-28  8:25           ` Tejun Heo [this message]
2011-06-28 12:30             ` Denys Vlasenko
2011-06-28 12:38               ` Tejun Heo
2011-06-28 16:35                 ` Oleg Nesterov
2011-06-28 16:49                   ` Tejun Heo
2011-06-28  0:31   ` Denys Vlasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110628082512.GA3386@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=vda.linux@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®