* [PATCH] leds: pca9532: change driver name to be unique
@ 2011-06-30 13:36 Wolfram Sang
2011-06-30 14:06 ` Jean Delvare
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2011-06-30 13:36 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-i2c, Wolfram Sang, Riku Voipio, Richard Purdie
This driver handles the variants pca9530-pca9533, so it chose the name
"pca953x". However, there is a gpio driver which decided on the same
name. As a result, those two can't be loaded at the same time. Add a
subsystem prefix to make the driver name unique. Device matching will
not suffer, because both are I2C drivers which match using a
i2c_device_id-table which is not altered.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
---
drivers/leds/leds-pca9532.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c
index d8d3a1e..a2c8746 100644
--- a/drivers/leds/leds-pca9532.c
+++ b/drivers/leds/leds-pca9532.c
@@ -88,7 +88,7 @@ static const struct pca9532_chip_info pca9532_chip_info_tbl[] = {
static struct i2c_driver pca9532_driver = {
.driver = {
- .name = "pca953x",
+ .name = "leds-pca953x",
},
.probe = pca9532_probe,
.remove = pca9532_remove,
--
1.7.5.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] leds: pca9532: change driver name to be unique
2011-06-30 13:36 [PATCH] leds: pca9532: change driver name to be unique Wolfram Sang
@ 2011-06-30 14:06 ` Jean Delvare
0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2011-06-30 14:06 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-kernel, linux-i2c, Riku Voipio, Richard Purdie
On Thu, 30 Jun 2011 15:36:21 +0200, Wolfram Sang wrote:
> This driver handles the variants pca9530-pca9533, so it chose the name
> "pca953x". However, there is a gpio driver which decided on the same
> name. As a result, those two can't be loaded at the same time. Add a
> subsystem prefix to make the driver name unique. Device matching will
> not suffer, because both are I2C drivers which match using a
> i2c_device_id-table which is not altered.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Which is (one of the reasons) why I hate "x" in driver names.
Acked-by: Jean Delvare <khali@linux-fr.org>
> ---
> drivers/leds/leds-pca9532.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c
> index d8d3a1e..a2c8746 100644
> --- a/drivers/leds/leds-pca9532.c
> +++ b/drivers/leds/leds-pca9532.c
> @@ -88,7 +88,7 @@ static const struct pca9532_chip_info pca9532_chip_info_tbl[] = {
>
> static struct i2c_driver pca9532_driver = {
> .driver = {
> - .name = "pca953x",
> + .name = "leds-pca953x",
> },
> .probe = pca9532_probe,
> .remove = pca9532_remove,
--
Jean Delvare
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-30 14:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-30 13:36 [PATCH] leds: pca9532: change driver name to be unique Wolfram Sang
2011-06-30 14:06 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®