From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Randy Dunlap <randy.dunlap@oracle.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [GIT PULL v2] sched: Make sleep inside atomic detection work on !PREEMPT
Date: Fri, 1 Jul 2011 19:29:34 +0200 [thread overview]
Message-ID: <20110701172934.GA6240@elte.hu> (raw)
In-Reply-To: <20110701164425.GG8508@somewhere>
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> On Fri, Jul 01, 2011 at 05:05:17PM +0200, Ingo Molnar wrote:
> >
> > -tip testing also found that m32r fails to build:
> >
> > /home/mingo/tip/kernel/sched.c: In function 'preempt_schedule':
> > /home/mingo/tip/kernel/sched.c:4364: error: implicit declaration of function 'add_preempt_count_notrace'
> > /home/mingo/tip/kernel/sched.c:4366: error: implicit declaration of function 'sub_preempt_count_notrace'
> >
> > due to:
> >
> > bdd4e85dc36cdbcfc1608a5b2a17c80a9db8986a is the first bad commit
> > commit bdd4e85dc36cdbcfc1608a5b2a17c80a9db8986a
> > Author: Frederic Weisbecker <fweisbec@gmail.com>
> > Date: Wed Jun 8 01:13:27 2011 +0200
> >
> > sched: Isolate preempt counting in its own config option
> >
> > Thanks,
> >
> > Ingo
>
> I have no clue how that did happen.
>
> Can you send me your config?
Just the m32r defconfig: m32700ut.smp_defconfig.
My guess would be that one of these:
include/linux/bit_spinlock.h | 2 +-
include/linux/hardirq.h | 4 ++--
include/linux/pagemap.h | 4 ++--
include/linux/preempt.h | 26 +++++++++++++++++---------
include/linux/rcupdate.h | 12 ++++++------
include/linux/sched.h | 2 +-
changed/exposed some header dependency quirk on m32r, failing the
build. Or m32r has some strange .config combo.
Thanks,
Ingo
next prev parent reply other threads:[~2011-07-01 17:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 13:30 [GIT PULL] " Frederic Weisbecker
2011-06-10 13:30 ` [PATCH 1/4] sched: Remove pointless in_atomic() definition check Frederic Weisbecker
2011-06-10 13:30 ` [PATCH 2/4] sched: Isolate preempt counting in its own config option Frederic Weisbecker
2011-06-10 13:30 ` [PATCH 3/4] sched: Make sleeping inside spinlock detection working in !CONFIG_PREEMPT Frederic Weisbecker
2011-06-10 13:30 ` [PATCH 4/4] sched: Generalize sleep inside spinlock detection Frederic Weisbecker
2011-06-10 15:37 ` Randy Dunlap
2011-06-23 4:19 ` KOSAKI Motohiro
2011-06-22 22:48 ` [GIT PULL v2] sched: Make sleep inside atomic detection work on !PREEMPT Frederic Weisbecker
2011-07-01 12:36 ` Ingo Molnar
2011-07-01 12:56 ` Frederic Weisbecker
2011-07-01 12:59 ` Ingo Molnar
2011-07-01 15:05 ` Ingo Molnar
2011-07-01 16:01 ` Frederic Weisbecker
2011-07-01 16:44 ` Frederic Weisbecker
2011-07-01 17:29 ` Ingo Molnar [this message]
2011-07-02 16:53 ` Frederic Weisbecker
2011-07-03 19:49 ` Ingo Molnar
2011-07-01 16:02 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110701172934.GA6240@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=randy.dunlap@oracle.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®