From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: [PATCH 1/4] sched: Remove pointless in_atomic() definition check
Date: Fri, 10 Jun 2011 15:30:19 +0200 [thread overview]
Message-ID: <1307712622-11104-2-git-send-email-fweisbec@gmail.com> (raw)
In-Reply-To: <1307712622-11104-1-git-send-email-fweisbec@gmail.com>
It's really supposed to be defined here. If it's not then
we actually want the build to crash so that we know it,
and not keep it silent.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
kernel/sched.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index fd18f39..01d9536 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -8028,7 +8028,6 @@ static inline int preempt_count_equals(int preempt_offset)
void __might_sleep(const char *file, int line, int preempt_offset)
{
-#ifdef in_atomic
static unsigned long prev_jiffy; /* ratelimiting */
if ((preempt_count_equals(preempt_offset) && !irqs_disabled()) ||
@@ -8050,7 +8049,6 @@ void __might_sleep(const char *file, int line, int preempt_offset)
if (irqs_disabled())
print_irqtrace_events(current);
dump_stack();
-#endif
}
EXPORT_SYMBOL(__might_sleep);
#endif
--
1.7.5.4
next prev parent reply other threads:[~2011-06-10 13:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 13:30 [GIT PULL] sched: Make sleep inside atomic detection work on !PREEMPT Frederic Weisbecker
2011-06-10 13:30 ` Frederic Weisbecker [this message]
2011-06-10 13:30 ` [PATCH 2/4] sched: Isolate preempt counting in its own config option Frederic Weisbecker
2011-06-10 13:30 ` [PATCH 3/4] sched: Make sleeping inside spinlock detection working in !CONFIG_PREEMPT Frederic Weisbecker
2011-06-10 13:30 ` [PATCH 4/4] sched: Generalize sleep inside spinlock detection Frederic Weisbecker
2011-06-10 15:37 ` Randy Dunlap
2011-06-23 4:19 ` KOSAKI Motohiro
2011-06-22 22:48 ` [GIT PULL v2] sched: Make sleep inside atomic detection work on !PREEMPT Frederic Weisbecker
2011-07-01 12:36 ` Ingo Molnar
2011-07-01 12:56 ` Frederic Weisbecker
2011-07-01 12:59 ` Ingo Molnar
2011-07-01 15:05 ` Ingo Molnar
2011-07-01 16:01 ` Frederic Weisbecker
2011-07-01 16:44 ` Frederic Weisbecker
2011-07-01 17:29 ` Ingo Molnar
2011-07-02 16:53 ` Frederic Weisbecker
2011-07-03 19:49 ` Ingo Molnar
2011-07-01 16:02 ` Frederic Weisbecker
-- strict thread matches above, loose matches on Subject: below --
2011-06-08 17:48 [PATCH 0/4] " Frederic Weisbecker
2011-06-08 17:48 ` [PATCH 1/4] sched: Remove pointless in_atomic() definition check Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307712622-11104-2-git-send-email-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®