* [PATCH] PCI: Assign values to 'pci_obff_signal_type' enumeration constants
@ 2011-07-07 21:00 Myron Stowe
2011-07-22 15:23 ` Jesse Barnes
0 siblings, 1 reply; 2+ messages in thread
From: Myron Stowe @ 2011-07-07 21:00 UTC (permalink / raw)
To: jbarnes; +Cc: linux-pci, linux-kernel
From: Myron Stowe <mstowe@redhat.com>
'pci_obff_signal_type' is passed between drivers and the kernel API.
This patch explicitly assigns values to the enumeration type's constants
which aids in detecting any future changes or additions that would break
the kernel's ABI.
No functional change.
Signed-off-by: Myron Stowe <myron.stowe@redhat.com>
---
include/linux/pci.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/pci.h b/include/linux/pci.h
index c446b5c..6e96015 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -843,8 +843,8 @@ void pci_enable_ido(struct pci_dev *dev, unsigned long type);
void pci_disable_ido(struct pci_dev *dev, unsigned long type);
enum pci_obff_signal_type {
- PCI_EXP_OBFF_SIGNAL_L0,
- PCI_EXP_OBFF_SIGNAL_ALWAYS,
+ PCI_EXP_OBFF_SIGNAL_L0 = 0,
+ PCI_EXP_OBFF_SIGNAL_ALWAYS = 1,
};
int pci_enable_obff(struct pci_dev *dev, enum pci_obff_signal_type);
void pci_disable_obff(struct pci_dev *dev);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] PCI: Assign values to 'pci_obff_signal_type' enumeration constants
2011-07-07 21:00 [PATCH] PCI: Assign values to 'pci_obff_signal_type' enumeration constants Myron Stowe
@ 2011-07-22 15:23 ` Jesse Barnes
0 siblings, 0 replies; 2+ messages in thread
From: Jesse Barnes @ 2011-07-22 15:23 UTC (permalink / raw)
To: Myron Stowe; +Cc: linux-pci, linux-kernel
On Thu, 07 Jul 2011 15:00:36 -0600
Myron Stowe <myron.stowe@redhat.com> wrote:
> From: Myron Stowe <mstowe@redhat.com>
>
> 'pci_obff_signal_type' is passed between drivers and the kernel API.
> This patch explicitly assigns values to the enumeration type's constants
> which aids in detecting any future changes or additions that would break
> the kernel's ABI.
>
> No functional change.
>
> Signed-off-by: Myron Stowe <myron.stowe@redhat.com>
> ---
Applied, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-22 15:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-07 21:00 [PATCH] PCI: Assign values to 'pci_obff_signal_type' enumeration constants Myron Stowe
2011-07-22 15:23 ` Jesse Barnes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®