From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: stable-review@kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk,
Florian Fainelli <florian@openwrt.org>,
Wim Van Sebroeck <wim@iguana.be>
Subject: [12/35] watchdog: mtx1-wdt: request gpio before using it
Date: Fri, 08 Jul 2011 16:00:28 -0700 [thread overview]
Message-ID: <20110708230110.730896583@clark.kroah.org> (raw)
In-Reply-To: <20110708230122.GA18807@kroah.com>
2.6.33-longterm review patch. If anyone has any objections, please let us know.
------------------
From: Florian Fainelli <florian@openwrt.org>
commit 9b19d40aa3ebaf1078779da10555da2ab8512422 upstream.
Otherwise, the gpiolib autorequest feature will produce a WARN_ON():
WARNING: at drivers/gpio/gpiolib.c:101 0x8020ec6c()
autorequest GPIO-215
[...]
Signed-off-by: Florian Fainelli <florian@openwrt.org>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/watchdog/mtx-1_wdt.c | 8 ++++++++
1 file changed, 8 insertions(+)
--- a/drivers/watchdog/mtx-1_wdt.c
+++ b/drivers/watchdog/mtx-1_wdt.c
@@ -211,6 +211,12 @@ static int __devinit mtx1_wdt_probe(stru
int ret;
mtx1_wdt_device.gpio = pdev->resource[0].start;
+ ret = gpio_request_one(mtx1_wdt_device.gpio,
+ GPIOF_OUT_INIT_HIGH, "mtx1-wdt");
+ if (ret < 0) {
+ dev_err(&pdev->dev, "failed to request gpio");
+ return ret;
+ }
spin_lock_init(&mtx1_wdt_device.lock);
init_completion(&mtx1_wdt_device.stop);
@@ -236,6 +242,8 @@ static int __devexit mtx1_wdt_remove(str
mtx1_wdt_device.queue = 0;
wait_for_completion(&mtx1_wdt_device.stop);
}
+
+ gpio_free(mtx1_wdt_device.gpio);
misc_deregister(&mtx1_wdt_misc);
return 0;
}
next prev parent reply other threads:[~2011-07-09 6:01 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 23:01 [00/35] 2.6.33.16-longterm review Greg KH
2011-07-08 23:00 ` [01/35] ksm: fix NULL pointer dereference in scan_get_next_rmap_item() Greg KH
2011-07-08 23:00 ` [02/35] migrate: dont account swapcache as shmem Greg KH
2011-07-08 23:00 ` [03/35] xen: partially revert "xen: set max_pfn_mapped to the last pfn mapped" Greg KH
2011-07-08 23:00 ` [04/35] clocksource: Make watchdog robust vs. interruption Greg KH
2011-07-08 23:00 ` [05/35] TTY: ldisc, do not close until there are readers Greg KH
2011-07-08 23:00 ` [06/35] xhci: Reject double add of active endpoints Greg KH
2011-07-08 23:00 ` [07/35] PM: Free memory bitmaps if opening /dev/snapshot fails Greg KH
2011-07-08 23:00 ` [08/35] ath5k: fix memory leak when fewer than N_PD_CURVES are in use Greg KH
2011-07-08 23:00 ` [09/35] ath9k: Fix suspend/resume when no interface is UP Greg KH
2011-07-08 23:00 ` [10/35] mm: fix negative commitlimit when gigantic hugepages are allocated Greg KH
2011-07-08 23:00 ` [11/35] [media] uvcvideo: Remove buffers from the queues when freeing Greg KH
2011-07-08 23:00 ` Greg KH [this message]
2011-07-08 23:00 ` [13/35] debugobjects: Fix boot crash when kmemleak and debugobjects enabled Greg KH
2011-07-08 23:00 ` [14/35] cfq-iosched: fix locking around ioc->ioc_data assignment Greg KH
2011-07-08 23:00 ` [15/35] cfq-iosched: fix a rcu warning Greg KH
2011-07-08 23:00 ` [16/35] i2c-taos-evm: Fix log messages Greg KH
2011-07-08 23:00 ` [17/35] md: avoid endless recovery loop when waiting for fail device to complete Greg KH
2011-07-08 23:00 ` [18/35] SUNRPC: Ensure the RPC client only quits on fatal signals Greg KH
2011-07-08 23:00 ` [19/35] 6pack,mkiss: fix lock inconsistency Greg KH
2011-07-08 23:00 ` [20/35] taskstats: dont allow duplicate entries in listener mode Greg KH
2011-07-08 23:00 ` [21/35] USB: dont let errors prevent system sleep Greg KH
2011-07-08 23:00 ` [22/35] USB: dont let the hub driver " Greg KH
2011-07-08 23:00 ` [23/35] uml: fix CONFIG_STATIC_LINK=y build failure with newer glibc Greg KH
2011-07-08 23:00 ` [24/35] um: os-linux/mem.c needs sys/stat.h Greg KH
2011-07-08 23:00 ` [25/35] netlink: Make nlmsg_find_attr take a const nlmsghdr* Greg KH
2011-07-08 23:00 ` [26/35] inet_diag: fix inet_diag_bc_audit() Greg KH
2011-07-08 23:00 ` [27/35] PM / Hibernate: Avoid hitting OOM during preallocation of memory Greg KH
2011-07-08 23:00 ` [28/35] PM / Hibernate: Fix free_unnecessary_pages() Greg KH
2011-07-08 23:00 ` [29/35] bug.h: Add WARN_RATELIMIT Greg KH
2011-07-08 23:00 ` [30/35] net: filter: Use WARN_RATELIMIT Greg KH
2011-07-08 23:00 ` [31/35] af_packet: prevent information leak Greg KH
2011-07-08 23:00 ` [32/35] net/ipv4: Check for mistakenly passed in non-IPv4 address Greg KH
2011-07-08 23:00 ` [33/35] ipv6/udp: Use the correct variable to determine non-blocking condition Greg KH
2011-07-08 23:00 ` [34/35] udp/recvmsg: Clear MSG_TRUNC flag when starting over for a new packet Greg KH
2011-07-08 23:00 ` [35/35] mm: prevent concurrent unmap_mapping_range() on the same inode Greg KH
-- strict thread matches above, loose matches on Subject: below --
2011-07-08 22:53 [00/35] 2.6.32.43-longterm review Greg KH
2011-07-08 22:50 ` [12/35] watchdog: mtx1-wdt: request gpio before using it Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110708230110.730896583@clark.kroah.org \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=florian@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable-review@kernel.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®