From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: stable-review@kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk,
NeilBrown <neilb@suse.de>
Subject: [17/35] md: avoid endless recovery loop when waiting for fail device to complete.
Date: Fri, 08 Jul 2011 16:00:33 -0700 [thread overview]
Message-ID: <20110708230111.216143870@clark.kroah.org> (raw)
In-Reply-To: <20110708230122.GA18807@kroah.com>
2.6.33-longterm review patch. If anyone has any objections, please let us know.
------------------
From: NeilBrown <neilb@suse.de>
commit 4274215d24633df7302069e51426659d4759c5ed upstream.
If a device fails in a way that causes pending request to take a while
to complete, md will not be able to immediately remove it from the
array in remove_and_add_spares.
It will then incorrectly look like a spare device and md will try to
recover it even though it is failed.
This leads to a recovery process starting and instantly aborting over
and over again.
We should check if the device is faulty before considering it to be a
spare. This will avoid trying to start a recovery that cannot
proceed.
This bug was introduced in 2.6.26 so that patch is suitable for any
kernel since then.
Reported-by: Jim Paradis <james.paradis@stratus.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/md/md.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -6862,6 +6862,7 @@ static int remove_and_add_spares(mddev_t
list_for_each_entry(rdev, &mddev->disks, same_set) {
if (rdev->raid_disk >= 0 &&
!test_bit(In_sync, &rdev->flags) &&
+ !test_bit(Faulty, &rdev->flags) &&
!test_bit(Blocked, &rdev->flags))
spares++;
if (rdev->raid_disk < 0
next prev parent reply other threads:[~2011-07-09 6:07 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 23:01 [00/35] 2.6.33.16-longterm review Greg KH
2011-07-08 23:00 ` [01/35] ksm: fix NULL pointer dereference in scan_get_next_rmap_item() Greg KH
2011-07-08 23:00 ` [02/35] migrate: dont account swapcache as shmem Greg KH
2011-07-08 23:00 ` [03/35] xen: partially revert "xen: set max_pfn_mapped to the last pfn mapped" Greg KH
2011-07-08 23:00 ` [04/35] clocksource: Make watchdog robust vs. interruption Greg KH
2011-07-08 23:00 ` [05/35] TTY: ldisc, do not close until there are readers Greg KH
2011-07-08 23:00 ` [06/35] xhci: Reject double add of active endpoints Greg KH
2011-07-08 23:00 ` [07/35] PM: Free memory bitmaps if opening /dev/snapshot fails Greg KH
2011-07-08 23:00 ` [08/35] ath5k: fix memory leak when fewer than N_PD_CURVES are in use Greg KH
2011-07-08 23:00 ` [09/35] ath9k: Fix suspend/resume when no interface is UP Greg KH
2011-07-08 23:00 ` [10/35] mm: fix negative commitlimit when gigantic hugepages are allocated Greg KH
2011-07-08 23:00 ` [11/35] [media] uvcvideo: Remove buffers from the queues when freeing Greg KH
2011-07-08 23:00 ` [12/35] watchdog: mtx1-wdt: request gpio before using it Greg KH
2011-07-08 23:00 ` [13/35] debugobjects: Fix boot crash when kmemleak and debugobjects enabled Greg KH
2011-07-08 23:00 ` [14/35] cfq-iosched: fix locking around ioc->ioc_data assignment Greg KH
2011-07-08 23:00 ` [15/35] cfq-iosched: fix a rcu warning Greg KH
2011-07-08 23:00 ` [16/35] i2c-taos-evm: Fix log messages Greg KH
2011-07-08 23:00 ` Greg KH [this message]
2011-07-08 23:00 ` [18/35] SUNRPC: Ensure the RPC client only quits on fatal signals Greg KH
2011-07-08 23:00 ` [19/35] 6pack,mkiss: fix lock inconsistency Greg KH
2011-07-08 23:00 ` [20/35] taskstats: dont allow duplicate entries in listener mode Greg KH
2011-07-08 23:00 ` [21/35] USB: dont let errors prevent system sleep Greg KH
2011-07-08 23:00 ` [22/35] USB: dont let the hub driver " Greg KH
2011-07-08 23:00 ` [23/35] uml: fix CONFIG_STATIC_LINK=y build failure with newer glibc Greg KH
2011-07-08 23:00 ` [24/35] um: os-linux/mem.c needs sys/stat.h Greg KH
2011-07-08 23:00 ` [25/35] netlink: Make nlmsg_find_attr take a const nlmsghdr* Greg KH
2011-07-08 23:00 ` [26/35] inet_diag: fix inet_diag_bc_audit() Greg KH
2011-07-08 23:00 ` [27/35] PM / Hibernate: Avoid hitting OOM during preallocation of memory Greg KH
2011-07-08 23:00 ` [28/35] PM / Hibernate: Fix free_unnecessary_pages() Greg KH
2011-07-08 23:00 ` [29/35] bug.h: Add WARN_RATELIMIT Greg KH
2011-07-08 23:00 ` [30/35] net: filter: Use WARN_RATELIMIT Greg KH
2011-07-08 23:00 ` [31/35] af_packet: prevent information leak Greg KH
2011-07-08 23:00 ` [32/35] net/ipv4: Check for mistakenly passed in non-IPv4 address Greg KH
2011-07-08 23:00 ` [33/35] ipv6/udp: Use the correct variable to determine non-blocking condition Greg KH
2011-07-08 23:00 ` [34/35] udp/recvmsg: Clear MSG_TRUNC flag when starting over for a new packet Greg KH
2011-07-08 23:00 ` [35/35] mm: prevent concurrent unmap_mapping_range() on the same inode Greg KH
-- strict thread matches above, loose matches on Subject: below --
2011-07-08 22:53 [00/35] 2.6.32.43-longterm review Greg KH
2011-07-08 22:50 ` [17/35] md: avoid endless recovery loop when waiting for fail device to complete Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110708230111.216143870@clark.kroah.org \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=stable-review@kernel.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®