* [PATCH] x86, quirks: use pci_dev->revision
@ 2011-07-11 15:01 Sergei Shtylyov
2011-07-21 10:11 ` [tip:x86/quirks] x86, quirks: Use pci_dev->revision tip-bot for Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2011-07-11 15:01 UTC (permalink / raw)
To: tglx, mingo, hpa, x86; +Cc: linux-kernel
This code uses PCI_CLASS_REVISION instead of PCI_REVISION_ID, so it wasn't
converted by commit 44c10138fd4bbc4b6d6bff0873c24902f2a9da65 (PCI: Change all
drivers to use pci_device->revision) before being moved to arch/x86/...
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
The patch is against the recent Linus' tree.
arch/x86/kernel/quirks.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Index: linux-2.6/arch/x86/kernel/quirks.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/quirks.c
+++ linux-2.6/arch/x86/kernel/quirks.c
@@ -10,7 +10,7 @@
static void __devinit quirk_intel_irqbalance(struct pci_dev *dev)
{
- u8 config, rev;
+ u8 config;
u16 word;
/* BIOS may enable hardware IRQ balancing for
@@ -18,8 +18,7 @@ static void __devinit quirk_intel_irqbal
* based platforms.
* Disable SW irqbalance/affinity on those platforms.
*/
- pci_read_config_byte(dev, PCI_CLASS_REVISION, &rev);
- if (rev > 0x9)
+ if (dev->revision > 0x9)
return;
/* enable access to config space*/
^ permalink raw reply [flat|nested] 3+ messages in thread* [tip:x86/quirks] x86, quirks: Use pci_dev->revision
2011-07-11 15:01 [PATCH] x86, quirks: use pci_dev->revision Sergei Shtylyov
@ 2011-07-21 10:11 ` tip-bot for Sergei Shtylyov
2011-07-22 15:44 ` Jesse Barnes
0 siblings, 1 reply; 3+ messages in thread
From: tip-bot for Sergei Shtylyov @ 2011-07-21 10:11 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, sshtylyov, jbarnes, davej, tglx, mingo
Commit-ID: 38175051f8e79c5e9f65daab7200fd8d1fa4a912
Gitweb: http://git.kernel.org/tip/38175051f8e79c5e9f65daab7200fd8d1fa4a912
Author: Sergei Shtylyov <sshtylyov@ru.mvista.com>
AuthorDate: Mon, 11 Jul 2011 19:01:38 +0400
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 21 Jul 2011 10:26:00 +0200
x86, quirks: Use pci_dev->revision
This code uses PCI_CLASS_REVISION instead of PCI_REVISION_ID, so
it wasn't converted by commit 44c10138fd4bbc ("PCI: Change all
drivers to use pci_device->revision") before being moved to arch/x86/...
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Dave Jones <davej@redhat.com>
Link: http://lkml.kernel.org/r/201107111901.39281.sshtylyov@ru.mvista.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/quirks.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/quirks.c b/arch/x86/kernel/quirks.c
index 8bbe8c5..b78643d 100644
--- a/arch/x86/kernel/quirks.c
+++ b/arch/x86/kernel/quirks.c
@@ -10,7 +10,7 @@
static void __devinit quirk_intel_irqbalance(struct pci_dev *dev)
{
- u8 config, rev;
+ u8 config;
u16 word;
/* BIOS may enable hardware IRQ balancing for
@@ -18,8 +18,7 @@ static void __devinit quirk_intel_irqbalance(struct pci_dev *dev)
* based platforms.
* Disable SW irqbalance/affinity on those platforms.
*/
- pci_read_config_byte(dev, PCI_CLASS_REVISION, &rev);
- if (rev > 0x9)
+ if (dev->revision > 0x9)
return;
/* enable access to config space*/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [tip:x86/quirks] x86, quirks: Use pci_dev->revision
2011-07-21 10:11 ` [tip:x86/quirks] x86, quirks: Use pci_dev->revision tip-bot for Sergei Shtylyov
@ 2011-07-22 15:44 ` Jesse Barnes
0 siblings, 0 replies; 3+ messages in thread
From: Jesse Barnes @ 2011-07-22 15:44 UTC (permalink / raw)
To: mingo, hpa, linux-kernel, sshtylyov, jbarnes, tglx, davej, mingo
Cc: linux-tip-commits
On Thu, 21 Jul 2011 10:11:42 GMT
tip-bot for Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:
> Commit-ID: 38175051f8e79c5e9f65daab7200fd8d1fa4a912
> Gitweb: http://git.kernel.org/tip/38175051f8e79c5e9f65daab7200fd8d1fa4a912
> Author: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> AuthorDate: Mon, 11 Jul 2011 19:01:38 +0400
> Committer: Ingo Molnar <mingo@elte.hu>
> CommitDate: Thu, 21 Jul 2011 10:26:00 +0200
>
> x86, quirks: Use pci_dev->revision
>
> This code uses PCI_CLASS_REVISION instead of PCI_REVISION_ID, so
> it wasn't converted by commit 44c10138fd4bbc ("PCI: Change all
> drivers to use pci_device->revision") before being moved to arch/x86/...
applied, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-22 15:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-11 15:01 [PATCH] x86, quirks: use pci_dev->revision Sergei Shtylyov
2011-07-21 10:11 ` [tip:x86/quirks] x86, quirks: Use pci_dev->revision tip-bot for Sergei Shtylyov
2011-07-22 15:44 ` Jesse Barnes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®