* [PATCH] x86: constify PCI raw ops structures
@ 2011-07-19 11:54 Jan Beulich
2011-07-21 7:04 ` Ingo Molnar
2011-07-22 15:24 ` Jesse Barnes
0 siblings, 2 replies; 4+ messages in thread
From: Jan Beulich @ 2011-07-19 11:54 UTC (permalink / raw)
To: mingo, tglx, hpa; +Cc: linux-kernel
As with any other such change, the goal is to prevent inadvertent
writes to these structures (assuming DEBUG_RODATA is enabled), and to
separate data (possibly frequently) written to from such never getting
modified.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
---
arch/x86/include/asm/pci_x86.h | 6 +++---
arch/x86/pci/ce4100.c | 2 +-
arch/x86/pci/common.c | 4 ++--
arch/x86/pci/direct.c | 6 +++---
arch/x86/pci/mmconfig_32.c | 2 +-
arch/x86/pci/mmconfig_64.c | 2 +-
arch/x86/pci/numaq_32.c | 2 +-
arch/x86/pci/olpc.c | 2 +-
arch/x86/pci/pcbios.c | 4 ++--
9 files changed, 15 insertions(+), 15 deletions(-)
--- 3.0-rc7/arch/x86/include/asm/pci_x86.h
+++ 3.0-rc7-x86-pci-raw-ops-const/arch/x86/include/asm/pci_x86.h
@@ -99,10 +99,10 @@ struct pci_raw_ops {
int reg, int len, u32 val);
};
-extern struct pci_raw_ops *raw_pci_ops;
-extern struct pci_raw_ops *raw_pci_ext_ops;
+extern const struct pci_raw_ops *raw_pci_ops;
+extern const struct pci_raw_ops *raw_pci_ext_ops;
-extern struct pci_raw_ops pci_direct_conf1;
+extern const struct pci_raw_ops pci_direct_conf1;
extern bool port_cf9_safe;
/* arch_initcall level */
--- 3.0-rc7/arch/x86/pci/ce4100.c
+++ 3.0-rc7-x86-pci-raw-ops-const/arch/x86/pci/ce4100.c
@@ -302,7 +302,7 @@ static int ce4100_conf_write(unsigned in
return pci_direct_conf1.write(seg, bus, devfn, reg, len, value);
}
-struct pci_raw_ops ce4100_pci_conf = {
+static const struct pci_raw_ops ce4100_pci_conf = {
.read = ce4100_conf_read,
.write = ce4100_conf_write,
};
--- 3.0-rc7/arch/x86/pci/common.c
+++ 3.0-rc7-x86-pci-raw-ops-const/arch/x86/pci/common.c
@@ -33,8 +33,8 @@ int noioapicreroute = 1;
int pcibios_last_bus = -1;
unsigned long pirq_table_addr;
struct pci_bus *pci_root_bus;
-struct pci_raw_ops *raw_pci_ops;
-struct pci_raw_ops *raw_pci_ext_ops;
+const struct pci_raw_ops *__read_mostly raw_pci_ops;
+const struct pci_raw_ops *__read_mostly raw_pci_ext_ops;
int raw_pci_read(unsigned int domain, unsigned int bus, unsigned int devfn,
int reg, int len, u32 *val)
--- 3.0-rc7/arch/x86/pci/direct.c
+++ 3.0-rc7-x86-pci-raw-ops-const/arch/x86/pci/direct.c
@@ -79,7 +79,7 @@ static int pci_conf1_write(unsigned int
#undef PCI_CONF1_ADDRESS
-struct pci_raw_ops pci_direct_conf1 = {
+const struct pci_raw_ops pci_direct_conf1 = {
.read = pci_conf1_read,
.write = pci_conf1_write,
};
@@ -173,7 +173,7 @@ static int pci_conf2_write(unsigned int
#undef PCI_CONF2_ADDRESS
-struct pci_raw_ops pci_direct_conf2 = {
+static const struct pci_raw_ops pci_direct_conf2 = {
.read = pci_conf2_read,
.write = pci_conf2_write,
};
@@ -189,7 +189,7 @@ struct pci_raw_ops pci_direct_conf2 = {
* This should be close to trivial, but it isn't, because there are buggy
* chipsets (yes, you guessed it, by Intel and Compaq) that have no class ID.
*/
-static int __init pci_sanity_check(struct pci_raw_ops *o)
+static int __init pci_sanity_check(const struct pci_raw_ops *o)
{
u32 x = 0;
int year, devfn;
--- 3.0-rc7/arch/x86/pci/mmconfig_32.c
+++ 3.0-rc7-x86-pci-raw-ops-const/arch/x86/pci/mmconfig_32.c
@@ -117,7 +117,7 @@ static int pci_mmcfg_write(unsigned int
return 0;
}
-static struct pci_raw_ops pci_mmcfg = {
+static const struct pci_raw_ops pci_mmcfg = {
.read = pci_mmcfg_read,
.write = pci_mmcfg_write,
};
--- 3.0-rc7/arch/x86/pci/mmconfig_64.c
+++ 3.0-rc7-x86-pci-raw-ops-const/arch/x86/pci/mmconfig_64.c
@@ -81,7 +81,7 @@ static int pci_mmcfg_write(unsigned int
return 0;
}
-static struct pci_raw_ops pci_mmcfg = {
+static const struct pci_raw_ops pci_mmcfg = {
.read = pci_mmcfg_read,
.write = pci_mmcfg_write,
};
--- 3.0-rc7/arch/x86/pci/numaq_32.c
+++ 3.0-rc7-x86-pci-raw-ops-const/arch/x86/pci/numaq_32.c
@@ -108,7 +108,7 @@ static int pci_conf1_mq_write(unsigned i
#undef PCI_CONF1_MQ_ADDRESS
-static struct pci_raw_ops pci_direct_conf1_mq = {
+static const struct pci_raw_ops pci_direct_conf1_mq = {
.read = pci_conf1_mq_read,
.write = pci_conf1_mq_write
};
--- 3.0-rc7/arch/x86/pci/olpc.c
+++ 3.0-rc7-x86-pci-raw-ops-const/arch/x86/pci/olpc.c
@@ -297,7 +297,7 @@ static int pci_olpc_write(unsigned int s
return 0;
}
-static struct pci_raw_ops pci_olpc_conf = {
+static const struct pci_raw_ops pci_olpc_conf = {
.read = pci_olpc_read,
.write = pci_olpc_write,
};
--- 3.0-rc7/arch/x86/pci/pcbios.c
+++ 3.0-rc7-x86-pci-raw-ops-const/arch/x86/pci/pcbios.c
@@ -301,7 +301,7 @@ static int pci_bios_write(unsigned int s
* Function table for BIOS32 access
*/
-static struct pci_raw_ops pci_bios_access = {
+static const struct pci_raw_ops pci_bios_access = {
.read = pci_bios_read,
.write = pci_bios_write
};
@@ -310,7 +310,7 @@ static struct pci_raw_ops pci_bios_acces
* Try to find PCI BIOS.
*/
-static struct pci_raw_ops * __devinit pci_find_bios(void)
+static const struct pci_raw_ops * __devinit pci_find_bios(void)
{
union bios32 *check;
unsigned char sum;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: constify PCI raw ops structures
2011-07-19 11:54 [PATCH] x86: constify PCI raw ops structures Jan Beulich
@ 2011-07-21 7:04 ` Ingo Molnar
2011-07-21 19:57 ` Jesse Barnes
2011-07-22 15:24 ` Jesse Barnes
1 sibling, 1 reply; 4+ messages in thread
From: Ingo Molnar @ 2011-07-21 7:04 UTC (permalink / raw)
To: Jan Beulich, Jesse Barnes; +Cc: tglx, hpa, linux-kernel
* Jan Beulich <JBeulich@novell.com> wrote:
> As with any other such change, the goal is to prevent inadvertent
> writes to these structures (assuming DEBUG_RODATA is enabled), and to
> separate data (possibly frequently) written to from such never getting
> modified.
>
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
>
> ---
> arch/x86/include/asm/pci_x86.h | 6 +++---
> arch/x86/pci/ce4100.c | 2 +-
> arch/x86/pci/common.c | 4 ++--
> arch/x86/pci/direct.c | 6 +++---
> arch/x86/pci/mmconfig_32.c | 2 +-
> arch/x86/pci/mmconfig_64.c | 2 +-
> arch/x86/pci/numaq_32.c | 2 +-
> arch/x86/pci/olpc.c | 2 +-
> arch/x86/pci/pcbios.c | 4 ++--
> 9 files changed, 15 insertions(+), 15 deletions(-)
Reviewed-by: Ingo Molnar <mingo@elte.hu>
It's a patch for Jesse's PCI tree i suspect.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: constify PCI raw ops structures
2011-07-21 7:04 ` Ingo Molnar
@ 2011-07-21 19:57 ` Jesse Barnes
0 siblings, 0 replies; 4+ messages in thread
From: Jesse Barnes @ 2011-07-21 19:57 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Jan Beulich, tglx, hpa, linux-kernel
On Thu, 21 Jul 2011 09:04:59 +0200
Ingo Molnar <mingo@elte.hu> wrote:
>
> * Jan Beulich <JBeulich@novell.com> wrote:
>
> > As with any other such change, the goal is to prevent inadvertent
> > writes to these structures (assuming DEBUG_RODATA is enabled), and to
> > separate data (possibly frequently) written to from such never getting
> > modified.
> >
> > Signed-off-by: Jan Beulich <jbeulich@novell.com>
> >
> > ---
> > arch/x86/include/asm/pci_x86.h | 6 +++---
> > arch/x86/pci/ce4100.c | 2 +-
> > arch/x86/pci/common.c | 4 ++--
> > arch/x86/pci/direct.c | 6 +++---
> > arch/x86/pci/mmconfig_32.c | 2 +-
> > arch/x86/pci/mmconfig_64.c | 2 +-
> > arch/x86/pci/numaq_32.c | 2 +-
> > arch/x86/pci/olpc.c | 2 +-
> > arch/x86/pci/pcbios.c | 4 ++--
> > 9 files changed, 15 insertions(+), 15 deletions(-)
>
> Reviewed-by: Ingo Molnar <mingo@elte.hu>
>
> It's a patch for Jesse's PCI tree i suspect.
Yep, I like it, I'll add it to my queue.
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: constify PCI raw ops structures
2011-07-19 11:54 [PATCH] x86: constify PCI raw ops structures Jan Beulich
2011-07-21 7:04 ` Ingo Molnar
@ 2011-07-22 15:24 ` Jesse Barnes
1 sibling, 0 replies; 4+ messages in thread
From: Jesse Barnes @ 2011-07-22 15:24 UTC (permalink / raw)
To: Jan Beulich; +Cc: mingo, tglx, hpa, linux-kernel
On Tue, 19 Jul 2011 12:54:10 +0100
"Jan Beulich" <JBeulich@novell.com> wrote:
> As with any other such change, the goal is to prevent inadvertent
> writes to these structures (assuming DEBUG_RODATA is enabled), and to
> separate data (possibly frequently) written to from such never getting
> modified.
>
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
>
> ---
> arch/x86/include/asm/pci_x86.h | 6 +++---
> arch/x86/pci/ce4100.c | 2 +-
> arch/x86/pci/common.c | 4 ++--
> arch/x86/pci/direct.c | 6 +++---
> arch/x86/pci/mmconfig_32.c | 2 +-
> arch/x86/pci/mmconfig_64.c | 2 +-
> arch/x86/pci/numaq_32.c | 2 +-
> arch/x86/pci/olpc.c | 2 +-
> arch/x86/pci/pcbios.c | 4 ++--
> 9 files changed, 15 insertions(+), 15 deletions(-)
Applied, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-22 15:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-19 11:54 [PATCH] x86: constify PCI raw ops structures Jan Beulich
2011-07-21 7:04 ` Ingo Molnar
2011-07-21 19:57 ` Jesse Barnes
2011-07-22 15:24 ` Jesse Barnes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®