[PATCH] genksyms: Use same type in loop comparison

[PATCH] genksyms: Use same type in loop comparison

[Jesper Juhl]

The ARRAY_SIZE macro in scripts/genksyms/genksyms.c returns a value of
type size_t. That value is being compared to a variable of type int in
a loop in read_node(). Change the int variable to size_t type as well,
so we don't do signed vs unsigned type comparisons with all the
potential promotion/sign extension trouble that can cause (also
silences compiler warnings at high levels of warnings).

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
 scripts/genksyms/genksyms.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/genksyms/genksyms.c b/scripts/genksyms/genksyms.c
index f9e7553..6d3fda0 100644
--- a/scripts/genksyms/genksyms.c
+++ b/scripts/genksyms/genksyms.c
@@ -448,7 +448,7 @@ static struct string_list *read_node(FILE *f)
 	node.string = buffer;
 
 	if (node.string[1] == '#') {
-		int n;
+		size_t n;
 
 		for (n = 0; n < ARRAY_SIZE(symbol_types); n++) {
 			if (node.string[0] == symbol_types[n].n) {
-- 
1.7.6


-- 
Jesper Juhl <jj@chaosbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

Re: [PATCH] genksyms: Use same type in loop comparison

[Michal Marek]

On Tue, Jul 12, 2011 at 12:32:04AM +0200, Jesper Juhl wrote:
> The ARRAY_SIZE macro in scripts/genksyms/genksyms.c returns a value of
> type size_t. That value is being compared to a variable of type int in
> a loop in read_node(). Change the int variable to size_t type as well,
> so we don't do signed vs unsigned type comparisons with all the
> potential promotion/sign extension trouble that can cause (also
> silences compiler warnings at high levels of warnings).
> 
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>

Applied to kbuid-2.6.git#kbuild, thanks.

Michal