From: Tejun Heo <tj@kernel.org>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-ide@vger.kernel.org, Valdis.Kletnieks@vt.edu,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Jeff Garzik <jgarzik@pobox.com>,
Michael Leun <lkml20100708@newton.leun.net>,
linux-kernel@vger.kernel.org, Jian Peng <jipeng2005@gmail.com>,
Kevin Cernekee <cernekee@gmail.com>
Subject: Re: ahci_start_engine compliance with AHCI spec
Date: Thu, 4 Aug 2011 11:44:19 +0200 [thread overview]
Message-ID: <20110804094419.GA2731@htj.dyndns.org> (raw)
In-Reply-To: <CAN8TOE8ZoE0xRvLPhDZtKZSwXg1mQLGtp8f2C75S+XuCrFM1YA@mail.gmail.com>
Hello,
On Tue, Aug 02, 2011 at 05:06:13PM -0700, Brian Norris wrote:
> Can DRQ be set from 0->1 without a software-initiated action? I didn't
> think it was directly tied to PHY events, and so we can fairly well
> predict that it will remain 0.
Sure it can. It's updated by Register D2H FISes sent by the device.
It can change after a PHY event; otherwise, I don't think it would get
set during init without any command in flight, right?
> Yes, I believe the hardware designers know how buggy this is...but
> it's still worth some effort to fix the software as well as possible
> for current hardware behavior.
Yeap, sure, let's get it working for majority of cases. I just wanted
to point out that the hardware eventually needs to be fixed.
Thanks.
--
tejun
prev parent reply other threads:[~2011-08-04 9:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 23:01 Brian Norris
2011-07-13 13:14 ` Tejun Heo
2011-07-18 18:40 ` Brian Norris
2011-07-21 8:49 ` Tejun Heo
2011-07-21 17:13 ` Brian Norris
2011-07-22 9:03 ` Tejun Heo
2011-07-22 9:41 ` [PATCH #upstream] ahci: start engine only during soft/hard resets Tejun Heo
2011-07-22 20:41 ` Brian Norris
2011-07-23 22:12 ` Jeff Garzik
2011-08-03 0:06 ` ahci_start_engine compliance with AHCI spec Brian Norris
2011-08-04 9:44 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110804094419.GA2731@htj.dyndns.org \
--to=tj@kernel.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=cernekee@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=jgarzik@pobox.com \
--cc=jipeng2005@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml20100708@newton.leun.net \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®