From: Andrew Morton <akpm@linux-foundation.org>
To: Tejun Heo <tj@kernel.org>
Cc: Rabin Vincent <rabin@rab.in>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] stop_machine: build unconditionally if SMP
Date: Sat, 6 Aug 2011 16:38:37 -0700 [thread overview]
Message-ID: <20110806163837.881d70af.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110806080323.GB23937@htj.dyndns.org>
On Sat, 6 Aug 2011 10:03:23 +0200 Tejun Heo <tj@kernel.org> wrote:
> Hello,
>
> On Sat, Aug 06, 2011 at 12:31:13PM +0530, Rabin Vincent wrote:
> > stop_machine() is built for "(SMP && MODULE_UNLOAD) || HOTPLUG_CPU", but
> > is also used by the timekeeping code, the mm code, ftrace, and couple of
> > things in arch/*. Just build it if we're using SMP, like it's already
> > the case on x86.
> >
> > Cc: x86@kernel.org
> > Cc: Tejun Heo <tj@kernel.org>
> > Signed-off-by: Rabin Vincent <rabin@rab.in>
>
> Yeah, looks good to me.
>
> Acked-by: Tejun Heo <tj@kernel.org>
>
> Andrew, can you please route this one?
>
Sure.
The priority is unclear. It appears that the patch fixes a build error
under sone circumstances in current mainline?
next prev parent reply other threads:[~2011-08-06 23:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-06 7:01 Rabin Vincent
2011-08-06 8:03 ` Tejun Heo
2011-08-06 23:38 ` Andrew Morton [this message]
2011-08-07 7:39 ` Tejun Heo
2011-08-07 9:30 ` Rabin Vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110806163837.881d70af.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rabin@rab.in \
--cc=tj@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®