mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Rabin Vincent <rabin@rab.in>,
	linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] stop_machine: build unconditionally if SMP
Date: Sun, 7 Aug 2011 09:39:16 +0200	[thread overview]
Message-ID: <20110807073916.GA13298@mtj.dyndns.org> (raw)
In-Reply-To: <20110806163837.881d70af.akpm@linux-foundation.org>

Hello,

On Sat, Aug 06, 2011 at 04:38:37PM -0700, Andrew Morton wrote:
> The priority is unclear.  It appears that the patch fixes a build error
> under sone circumstances in current mainline?

I don't think it would have triggered build error as there are dummy
functions which just calls the function on the local CPU, but it does
look pretty broken now.  e.g. ia64 supports memory hotplug which
depends on stop machine but it would still be using dummy local
version, which can't be right.

Robin, is there an open bug report regarding this issue?  I'm not sure
enough to suggest -stable but definitely mainline material.

Thanks.

-- 
tejun

  reply	other threads:[~2011-08-07  7:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-06  7:01 Rabin Vincent
2011-08-06  8:03 ` Tejun Heo
2011-08-06 23:38   ` Andrew Morton
2011-08-07  7:39     ` Tejun Heo [this message]
2011-08-07  9:30       ` Rabin Vincent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110807073916.GA13298@mtj.dyndns.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rabin@rab.in \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®