* drivers/target/target_core_transport.c breakage on i386
@ 2011-08-08 0:10 Al Viro
2011-08-08 19:12 ` Nicholas A. Bellinger
0 siblings, 1 reply; 2+ messages in thread
From: Al Viro @ 2011-08-08 0:10 UTC (permalink / raw)
To: agrover; +Cc: linux-kernel
In commit ec98f7825c6eaa4a9afb0eb518826efc8a2ed4a2
Author: Andy Grover <agrover@redhat.com>
Date: Wed Jul 20 19:28:46 2011 +0000
target: Eliminate usage of struct se_mem
we got
+ task_count = DIV_ROUND_UP(sectors, dev_max_sectors);
and that's sector_t/sector_t. 64bit division on i386 is no-no in
the kernel - it emits __udivdi3 call and it's not there. Can
sectors really reach 2^32 here?
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: drivers/target/target_core_transport.c breakage on i386
2011-08-08 0:10 drivers/target/target_core_transport.c breakage on i386 Al Viro
@ 2011-08-08 19:12 ` Nicholas A. Bellinger
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas A. Bellinger @ 2011-08-08 19:12 UTC (permalink / raw)
To: Al Viro; +Cc: agrover, linux-kernel, target-devel
On Mon, 2011-08-08 at 01:10 +0100, Al Viro wrote:
> In commit ec98f7825c6eaa4a9afb0eb518826efc8a2ed4a2
> Author: Andy Grover <agrover@redhat.com>
> Date: Wed Jul 20 19:28:46 2011 +0000
>
> target: Eliminate usage of struct se_mem
>
> we got
> + task_count = DIV_ROUND_UP(sectors, dev_max_sectors);
> and that's sector_t/sector_t. 64bit division on i386 is no-no in
> the kernel - it emits __udivdi3 call and it's not there. Can
> sectors really reach 2^32 here?
>
Hi Al,
Just a heads up that this was caught this before -rc1, and we ended up
adding DIV_ROUND_UP_ULL using do_div() for the 32-bit case here, and
another DIV_ROUND_UP_SECTOR_T macro that target_core_transport.c is now
using to address this for i386.
kernel.h: Add DIV_ROUND_UP_ULL and DIV_ROUND_UP_SECTOR_T macro usage
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff_plain;h=36a26c69b4c70396ef569c3452690fba0c1dec08
Thanks,
--nab
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-08 19:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-08 0:10 drivers/target/target_core_transport.c breakage on i386 Al Viro
2011-08-08 19:12 ` Nicholas A. Bellinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome