From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Keith Packard <keithp@keithp.com>
Cc: Dave Airlie <airlied@redhat.com>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 3/4] drm/i915: Fix PCH port pipe select in CPT disable paths
Date: Mon, 8 Aug 2011 09:31:37 -0700 [thread overview]
Message-ID: <20110808093137.5ed7b8ba@jbarnes-desktop> (raw)
In-Reply-To: <1312653248-3487-4-git-send-email-keithp@keithp.com>
On Sat, 6 Aug 2011 10:54:07 -0700
Keith Packard <keithp@keithp.com> wrote:
> CPT pipe select is different from previous generations (using two bits
> instead of one). All of the paths from intel_disable_pch_ports were
> not making this distinction.
>
> Mode setting with pipe A turned off would then also force all outputs
> on pipe B to get turned off as the disable code would mistakenly
> decide that all of these outputs were on pipe A and turn them off.
>
> This is an extension of the CPT DP disable fix (why didn't I fix this then?)
>
> Signed-off-by: Keith Packard <keithp@keithp.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 13 ++-----
> drivers/gpu/drm/i915/intel_display.c | 60 ++++++++++++++++++++++++++++++---
> 2 files changed, 58 insertions(+), 15 deletions(-)
>
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2011-08-08 16:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-06 17:54 drm/i915: Disabling unused outputs on CPT is broken Keith Packard
2011-08-06 17:54 ` [PATCH 1/4] drm/i915: Wait for LVDS panel power sequence Keith Packard
2011-08-08 16:27 ` [Intel-gfx] " Jesse Barnes
2011-08-08 18:40 ` Keith Packard
2011-08-08 18:50 ` Jesse Barnes
2011-08-06 17:54 ` [PATCH 2/4] drm/i915: Leave LVDS registers unlocked Keith Packard
2011-08-08 16:30 ` [Intel-gfx] " Jesse Barnes
2011-08-08 18:25 ` Keith Packard
2011-08-08 18:42 ` Keith Packard
2011-08-08 18:49 ` Jesse Barnes
2011-08-08 19:53 ` Keith Packard
2011-08-08 20:01 ` Jesse Barnes
2011-08-08 20:24 ` Keith Packard
2011-08-08 20:25 ` Jesse Barnes
2011-08-06 17:54 ` [PATCH 3/4] drm/i915: Fix PCH port pipe select in CPT disable paths Keith Packard
2011-08-08 16:31 ` Jesse Barnes [this message]
2011-08-06 17:54 ` [PATCH 4/4] drm/i915: Remove unused 'reg' argument to dp_pipe_enabled Keith Packard
2011-08-08 16:32 ` [Intel-gfx] " Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110808093137.5ed7b8ba@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome