mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] sparc64: remove unnecessary macros from spinlock_64.h
@ 2011-08-15 20:10 Mikael Pettersson
  2011-08-15 21:37 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Mikael Pettersson @ 2011-08-15 20:10 UTC (permalink / raw)
  To: sparclinux; +Cc: linux-kernel

The sparc64 spinlock_64.h contains a number of operations defined
first as static inline functions, and then as macros with the same
names and parameters as the functions.  Maybe this was needed at
some point in the past, but now nothing seems to depend on these
macros (checked with a recursive grep looking for ifdefs on these
names).  Other archs don't define these identity-macros.

So this patch deletes these unnecessary macros.

Compile-tested with sparc64_defconfig.

Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
---
--- linux-3.1-rc2/arch/sparc/include/asm/spinlock_64.h.~1~	2011-05-19 06:06:34.000000000 +0200
+++ linux-3.1-rc2/arch/sparc/include/asm/spinlock_64.h	2011-08-15 20:51:27.000000000 +0200
@@ -210,14 +210,8 @@ static int inline arch_write_trylock(arc
 	return result;
 }
 
-#define arch_read_lock(p)	arch_read_lock(p)
 #define arch_read_lock_flags(p, f) arch_read_lock(p)
-#define arch_read_trylock(p)	arch_read_trylock(p)
-#define arch_read_unlock(p)	arch_read_unlock(p)
-#define arch_write_lock(p)	arch_write_lock(p)
 #define arch_write_lock_flags(p, f) arch_write_lock(p)
-#define arch_write_unlock(p)	arch_write_unlock(p)
-#define arch_write_trylock(p)	arch_write_trylock(p)
 
 #define arch_read_can_lock(rw)		(!((rw)->lock & 0x80000000UL))
 #define arch_write_can_lock(rw)	(!(rw)->lock)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] sparc64: remove unnecessary macros from spinlock_64.h
  2011-08-15 20:10 [PATCH] sparc64: remove unnecessary macros from spinlock_64.h Mikael Pettersson
@ 2011-08-15 21:37 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-08-15 21:37 UTC (permalink / raw)
  To: mikpe; +Cc: sparclinux, linux-kernel

From: Mikael Pettersson <mikpe@it.uu.se>
Date: Mon, 15 Aug 2011 22:10:31 +0200

> The sparc64 spinlock_64.h contains a number of operations defined
> first as static inline functions, and then as macros with the same
> names and parameters as the functions.  Maybe this was needed at
> some point in the past, but now nothing seems to depend on these
> macros (checked with a recursive grep looking for ifdefs on these
> names).  Other archs don't define these identity-macros.
> 
> So this patch deletes these unnecessary macros.
> 
> Compile-tested with sparc64_defconfig.
> 
> Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-08-15 21:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-15 20:10 [PATCH] sparc64: remove unnecessary macros from spinlock_64.h Mikael Pettersson
2011-08-15 21:37 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®